T13819 remove minifiers #13820
Merged
T13819 remove minifiers #13820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upstream/4.0.x: [4.0.x] - Added unicode flag for email filter
* upstream/4.0.x: Updated changelog Updated CFLAG default build param keep the actionName as set, do cache the methodName in `getActiveMethod` instead (use action mapping to cover Dispatcher `forward`ing case?) move formatter into setter give up on `camelize`, use a new approach unit tests Camel-case the action name (before call in handler) Correct pull request template Fix .editorconfig Amended .gitignore Bump version Fixed preparing release on AppVeyor Update change log Regenerated build Regenerated ext Updating the changelog
* upstream/4.0.x: Update CHANGELOG-4.0.md Updated changelog Added geSetMetaData test Modified some unit tests to use metaData Modified existing tests to work with the additional MetaData Modified Phalcon\Mvc\Model to use Phalcon\Message::setMetaData() instead of setModel() Added new MetaData variable to Phalcon\Message. Modified Phalcon\MessageInterface accordingly Corrected typo
|
cc @sergeyklay |
Codecov Report
@@ Coverage Diff @@
## 4.0.x #13820 +/- ##
==========================================
- Coverage 66.29% 66.25% -0.04%
==========================================
Files 452 450 -2
Lines 89864 89576 -288
==========================================
- Hits 59579 59353 -226
+ Misses 30285 30223 -62
Continue to review full report at Codecov.
|
sergeyklay
approved these changes
Feb 12, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Removed the external libraries from the source. Kept CssMin/JsMin files but they just return the original content back. In future versions of the framework these filters will either be removed or replaced with in house implementations or by using other libraries with free licenses.
Thanks