Add setContentlength() method to Phalcon\Http\Response

CHANGELOG.md

@@ -104,6 +104,7 @@
 - Amended `Phalcon\Mvc\RouterInterface` and `Phalcon\Mvc\Router`. Added missed `addPurge`, `addTrace` and `addConnect` methods
 - Fixed incorrect query when using NULL fields with `Phalcon\Validation\Validator\Uniqueness`
 - Fixed `Phalcon\Forms\Form::getValue`. Now Elements can have names that match with the internal Form getters [#10398](https://github.com/phalcon/cphalcon/issues/10398)
+- Add `setContentLength()` method to `Phalcon\Http\Response`
 
 # [2.0.13](https://github.com/phalcon/cphalcon/releases/tag/phalcon-v2.0.13) (2016-05-19)
 - Restored `Phalcon\Text::camelize` behavior [#11767](https://github.com/phalcon/cphalcon/issues/11767)

phalcon/http/response.zep

@@ -14,6 +14,7 @@
  +------------------------------------------------------------------------+
  | Authors: Andres Gutierrez <andres@phalconphp.com>                      |
  |          Eduar Carvajal <eduar@phalconphp.com>                         |
+ |          Zamrony P. Juhara <zamronypj@yahoo.com>                       |
  +------------------------------------------------------------------------+
  */
 
@@ -59,10 +60,6 @@ class Response implements ResponseInterface, InjectionAwareInterface
 
 	/**
 	 * Phalcon\Http\Response constructor
-	 *
-	 * @param string content
-	 * @param int code
-	 * @param string status
 	 */
 	public function __construct(content = null, code = null, status = null)
 	{
@@ -279,10 +276,6 @@ class Response implements ResponseInterface, InjectionAwareInterface
 	 *<code>
 	 *	$response->setHeader("Content-Type", "text/plain");
 	 *</code>
-	 *
-	 * @param string name
-	 * @param string value
-	 * @return \Phalcon\Http\Response
 	 */
 	public function setHeader(string name, value) -> <Response>
 	{
@@ -406,10 +399,6 @@ class Response implements ResponseInterface, InjectionAwareInterface
 	 *	$response->setContentType('application/pdf');
 	 *	$response->setContentType('text/plain', 'UTF-8');
 	 *</code>
-	 *
-	 * @param string contentType
-	 * @param string charset
-	 * @return \Phalcon\Http\Response
 	 */
 	public function setContentType(string contentType, charset = null) -> <Response>
 	{
@@ -422,6 +411,20 @@ class Response implements ResponseInterface, InjectionAwareInterface
 		return this;
 	}
 
+	/**
+	 * Sets the response content-length
+	 *
+	 *<code>
+	 *	$response->setContentLength(2048);
+	 *</code>
+	 */
+	public function setContentLength(int contentLength) -> <Response>
+	{
+		this->setHeader("Content-Length", contentLength);
+
+		return this;
+	}
+
 	/**
 	 * Set a custom ETag
 	 *
@@ -452,11 +455,6 @@ class Response implements ResponseInterface, InjectionAwareInterface
 	 *		"controller" => "index"
 	 *	));
 	 *</code>
-	 *
-	 * @param string|array location
-	 * @param boolean externalRedirect
-	 * @param int statusCode
-	 * @return \Phalcon\Http\Response
 	 */
 	public function redirect(location = null, boolean externalRedirect = false, int statusCode = 302) -> <Response>
 	{
@@ -542,9 +540,6 @@ class Response implements ResponseInterface, InjectionAwareInterface
 
 	/**
 	 * Appends a string to the HTTP response body
-	 *
-	 * @param string content
-	 * @return \Phalcon\Http\Response
 	 */
 	public function appendContent(content) -> <Response>
 	{
@@ -626,10 +621,6 @@ class Response implements ResponseInterface, InjectionAwareInterface
 
 	/**
 	 * Sets an attached file to be sent at the end of the request
-	 *
-	 * @param string filePath
-	 * @param string attachmentName
-	 * @return \Phalcon\Http\Response
 	 */
 	public function setFileToSend(string filePath, attachmentName = null, attachment = true) -> <Response>
 	{

phalcon/http/responseinterface.zep

@@ -14,6 +14,7 @@
  +------------------------------------------------------------------------+
  | Authors: Andres Gutierrez <andres@phalconphp.com>                      |
  |          Eduar Carvajal <eduar@phalconphp.com>                         |
+ |          Zamrony P. Juhara <zamronypj@yahoo.com>                       |
  +------------------------------------------------------------------------+
  */
 
@@ -41,10 +42,6 @@ interface ResponseInterface
 
 	/**
 	 * Overwrites a header in the response
-	 *
-	 * @param string name
-	 * @param string value
-	 * @return \Phalcon\Http\ResponseInterface
 	 */
 	public function setHeader(string name, value) -> <ResponseInterface>;
 
@@ -62,6 +59,7 @@ interface ResponseInterface
 	 * Sets output expire time header
 	 */
 	public function setExpires(<\DateTime> datetime) -> <ResponseInterface>;
+
 	/**
 	 * Sends a Not-Modified response
 	 */
@@ -76,13 +74,13 @@ interface ResponseInterface
 	 */
 	public function setContentType(string contentType, charset = null) -> <ResponseInterface>;
 
+	/**
+	 * Sets the response content-length
+	 */
+	public function setContentLength(int contentLength) -> <ResponseInterface>;
+
 	/**
 	 * Redirect by HTTP to another action or URL
-	 *
-	 * @param string location
-	 * @param boolean externalRedirect
-	 * @param int statusCode
-	 * @return \Phalcon\Http\ResponseInterface
 	 */
 	public function redirect(location = null, boolean externalRedirect = false, int statusCode = 302) -> <ResponseInterface>;
 
@@ -97,17 +95,11 @@ interface ResponseInterface
 	 *<code>
 	 *	response->setJsonContent(array("status" => "OK"));
 	 *</code>
-	 *
-	 * @param string content
-	 * @return \Phalcon\Http\ResponseInterface
 	 */
 	public function setJsonContent(content) -> <ResponseInterface>;
 
 	/**
 	 * Appends a string to the HTTP response body
-	 *
-	 * @param string content
-	 * @return \Phalcon\Http\ResponseInterface
 	 */
 	public function appendContent(content) -> <ResponseInterface>;
 
@@ -133,9 +125,6 @@ interface ResponseInterface
 
 	/**
 	 * Sets an attached file to be sent at the end of the request
-	 *
-	 * @param string filePath
-	 * @param string attachmentName
 	 */
 	public function setFileToSend(string filePath, attachmentName = null) -> <ResponseInterface>;
 

tests/unit/Http/ResponseTest.php

@@ -14,6 +14,7 @@
  * @link      http://www.phalconphp.com
  * @author    Andres Gutierrez <andres@phalconphp.com>
  * @author    Nikolaos Dimopoulos <nikos@phalconphp.com>
+ * @author    Zamrony P. Juhara <zamronypj@yahoo.com>
  * @package   Phalcon\Test\Unit\Http
  *
  * The contents of this file are subject to the New BSD License that is
@@ -261,6 +262,31 @@ function () {
         );
     }
 
+    /**
+     * Tests the setContentLength
+     *
+     * @author Zamrony P. Juhara <zamronypj@yahoo.com>
+     * @since  2016-07-18
+     */
+    public function testHttpResponseSetContentLength()
+    {
+        $this->specify(
+            "setContentLength is not setting the header properly",
+            function () {
+                $response = $this->getResponseObject();
+                $response->resetHeaders();
+                $response->setContentLength(100);
+
+                $expected = Headers::__set_state(
+                    [
+                        '_headers' => ['Content-Length' => 100]
+                    ]
+                );
+                expect($response->getHeaders())->equals($expected);
+            }
+        );
+    }
+
     /**
      * Tests the setContentType with charset
      *