Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setContentlength() method to Phalcon\Http\Response #11986

Merged
merged 1 commit into from
Jul 19, 2016
Merged

Add setContentlength() method to Phalcon\Http\Response #11986

merged 1 commit into from
Jul 19, 2016

Conversation

zamronypj
Copy link
Contributor

No description provided.

@sergeyklay sergeyklay mentioned this pull request Jul 18, 2016
Closed
@sergeyklay sergeyklay added the new feature request Planned Feature or New Feature Request label Jul 18, 2016
sergeyklay
sergeyklay reviewed Jul 18, 2016
View reviewed changes
phalcon/http/response.zep
@@ -14,6 +14,7 @@
+------------------------------------------------------------------------+
| Authors: Andres Gutierrez <andres@phalconphp.com> |
| Eduar Carvajal <eduar@phalconphp.com> |
| Zamrony P. Juhara <zamronypj@yahoo.com> |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new author just for doing a patch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? I thought every contributors have right to put their name. I thought we value every contribution even smallest one? I do not get financial reward to do this work so putting my name is my reward. Your statement discourages people to contribute.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically andres and eduar are added as authors always beacause they are authors of frameworks and you can you as author if you are creating new file, but othey than that authors should stay the same.

@sergeyklay
Copy link
Contributor

@zamronypj Could you please update CHANGELOG.md

@sergeyklay
Copy link
Contributor

@zamronypj Thank you for contributing. Few things..

  1. Don't add changes to the CHANGELOG.md which do not change the API (eg Remove unused comment)
  2. Always add changes to the bottom of list
  3. Could you please squash it into a single commit to keep the history clean?

I apologize for the inconvenience. Let me know if you need instructions.

@zamronypj
Add setContentlength() method to Phalcon\Http\Response
6cf38e4 
Remove charset from method comment

Remove @param and @return from method comment

Add entries to changelog.md

Update changelog.md
@sergeyklay sergeyklay merged commit a7d657c into phalcon:2.1.x Jul 19, 2016
@sergeyklay
Copy link
Contributor

Thanks

@zamronypj zamronypj deleted the experiment-2.1.x branch July 19, 2016 10:32
@sergeyklay sergeyklay added this to the 3.0.0 milestone Jul 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zamronypj @sergeyklay @Jurigag