Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEEDS REVIEW] Fix #1040 #1153

Closed
wants to merge 9 commits into from
Closed

[NEEDS REVIEW] Fix #1040 #1153

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bd10fbb
Fix #1040
sjinks Aug 24, 2013
0b96b3b
Updated tests
sjinks Aug 24, 2013
f93d584
Optimizations
sjinks Aug 24, 2013
db9d382
Interned strings
sjinks Aug 24, 2013
aaea07e
Make tests pass
sjinks Aug 25, 2013
5f85205
Test case for #1275
sjinks Oct 19, 2013
429d6d3
Fix #1275
sjinks Oct 19, 2013
6d74a38
Fix controller length for #1275
sjinks Oct 19, 2013
5d125cb
Fixing #1829
sjinks Jan 21, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix controller length for #1275
  • Loading branch information
@sjinks
sjinks committed Jan 21, 2014
commit 6d74a387802b330720a41c6d26e2bf86d02dbd00
4 changes: 4 additions & 0 deletions ext/mvc/dispatcher.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@ PHP_METHOD(Phalcon_Mvc_Dispatcher, getControllerName){
int len = Z_STRLEN_P(return_value);
memmove(c, c+1, len-1);
c[len-1] = 0;
c = erealloc(c, len);
if (likely(c != NULL)) {
RETVAL_STRINGL(c, len-1, 0);
}
}
}

Expand Down