[NEEDS REVIEW] Fix #1040 #1153
Closed
[NEEDS REVIEW] Fix #1040 #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -596,6 +596,9 @@ static inline int phalcon_dispatcher_fire_event(zval *return_value, zval *mgr, c | |||
| if (!phalcon_memnstr_str(handler_name, SL("\\"))) { | |||
| PHALCON_INIT_NVAR(camelized_class); | |||
| phalcon_camelize(camelized_class, handler_name); | |||
| } else if (phalcon_start_with_str(handler_name, SL("\\"))) { | |||
There was a problem hiding this comment.
Hack: when we don't want the controller name to be mangled, we prepend it with '' (pretending that the controller is in a namespace which effectively disables mangling). This code removes the extra slash.
|
Applied fix for #1275 as that issue was caused by this patch |
|
Rebased agianst the latest 1.3.0 |
(cherry picked from commit b617bab)
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1040
What this patch does is suppresses (un)camelize when controller name comes from the annotation parser (as in this case we will deal with the real controller name which does not need to be camelized).