Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR]: PHP 8.3 support #16477

Closed
Jeckerson opened this issue Dec 23, 2023 · 4 comments · Fixed by #16478
Closed

[NFR]: PHP 8.3 support #16477

Jeckerson opened this issue Dec 23, 2023 · 4 comments · Fixed by #16478
Assignees
Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request

Comments

@Jeckerson
Copy link
Member

Blocked by zephir-lang/zephir#2407

@Jeckerson Jeckerson added the new feature request Planned Feature or New Feature Request label Dec 23, 2023
@Jeckerson Jeckerson self-assigned this Dec 23, 2023
Jeckerson added a commit that referenced this issue Dec 23, 2023
Jeckerson added a commit that referenced this issue Dec 23, 2023
Jeckerson added a commit that referenced this issue Dec 23, 2023
Jeckerson added a commit that referenced this issue Dec 23, 2023
Jeckerson added a commit that referenced this issue Dec 23, 2023
Jeckerson added a commit that referenced this issue Dec 23, 2023
@Jeckerson Jeckerson linked a pull request Dec 23, 2023 that will close this issue
5 tasks
Jeckerson added a commit that referenced this issue Dec 23, 2023
Jeckerson added a commit that referenced this issue Dec 23, 2023
Jeckerson added a commit that referenced this issue Dec 23, 2023
Jeckerson added a commit that referenced this issue Dec 23, 2023
Jeckerson added a commit that referenced this issue Dec 23, 2023
Jeckerson added a commit that referenced this issue Dec 23, 2023
Jeckerson added a commit that referenced this issue Dec 23, 2023
Jeckerson added a commit that referenced this issue Dec 23, 2023
As now, it executes from composer's vendor directory
Jeckerson added a commit that referenced this issue Dec 23, 2023
niden added a commit that referenced this issue Dec 24, 2023
@niden niden added the 5.0 The issues we want to solve in the 5.0 release label Dec 24, 2023
@niden
Copy link
Member

niden commented Dec 24, 2023

Resolved in #16478

@niden niden closed this as completed Dec 24, 2023
@joseluisq
Copy link

joseluisq commented Jan 2, 2024

Does the latest phalcon 5.5.0 support PHP 8.3?

Because I got an error when I built it from the source using Docker.

$ uname -a
# Linux c0b179ebb845 6.4.16-linuxkit #1 SMP PREEMPT Thu Nov 16 10:49:20 UTC 2023 aarch64 Linux

$ git clone --depth=1 --branch=v5.5.0 https://github.com/phalcon/cphalcon.git /opt/phalcon
$ cd /opt/phalcon/build
$ sh ./install
$ cp -r phalcon/modules/phalcon.so "$(php -r 'echo ini_get("extension_dir");')"/
$ echo "extension=phalcon" > /usr/local/etc/php/conf.d/docker-php-ext-phalcon.ini

It builds successfully but fails If I test the phalcon.so module showing the error below.

Error relocating /usr/local/lib/php/extensions/no-debug-non-zts-20230831/phalcon.so: fast_add_function: symbol not found

$ php -r 'echo ini_get("extension_dir");'

# Warning: PHP Startup: Unable to load dynamic library 'phalcon' (tried: /usr/local/lib/php/extensions/no-debug-non-zts-20230831/phalcon (Error loading shared library /usr/local/lib/php/extensions/no-debug-non-zts-20230831/phalcon: No such file or directory), /usr/local/lib/php/extensions/no-debug-non-zts-20230831/phalcon.so (Error relocating /usr/local/lib/php/extensions/no-debug-non-zts-20230831/phalcon.so: fast_add_function: symbol not found)) in Unknown on line 0
# /usr/local/lib/php/extensions/no-debug-non-zts-20230831/: No such file or directory

Maybe I'm doing something wrong?

FYI I noted that the fast_add_function was removed from PHP 8.3 php/php-src@3b06618 perhaps fails because of that?

@Jeckerson
Copy link
Member Author

Jeckerson commented Jan 2, 2024

@joseluisq Try to install via PECL: pecl install phalcon.
For some reason build/ directory contains generated code of previous Zephir version which still contain fast_add_function() function.

If you really want to compile from source, try to regenerate via cd build/ && php gen-build.php

@joseluisq
Copy link

@Jeckerson good to know.
The last time that I tried pecl install phalcon on Docker + KVM I ran into a Virtual memory exhausted: Cannot allocate memory error.
So I will give cd build/ && php gen-build.php a try and let's see.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

3 participants