#16477 - Skip working tests with warnings in PHP8.3

phalcon · Dec 23, 2023 · 7c00830 · 7c00830
1 parent f6319f1
commit 7c00830
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 0 deletions.
diff --git a/tests/integration/Cache/Adapter/Stream/GetSetCest.php b/tests/integration/Cache/Adapter/Stream/GetSetCest.php
@@ -192,6 +192,10 @@ public function cacheAdapterStreamGetErrors(IntegrationTester $I)
     {
         $I->wantToTest('Cache\Adapter\Stream - get() - errors');
 
+        if (version_compare(PHP_VERSION, '8.3.0', '>=')) {
+            $I->markTestSkipped('Since PHP 8.3 warnings causing session ID/Name lock.');
+        }
+
         $serializer = new SerializerFactory();
         $adapter    = new Stream(
             $serializer,

diff --git a/tests/integration/Storage/Adapter/ExceptionsCest.php b/tests/integration/Storage/Adapter/ExceptionsCest.php
@@ -112,6 +112,10 @@ public function storageAdapterStreamGetErrors(IntegrationTester $I)
     {
         $I->wantToTest('Storage\Adapter\Stream - get() - errors');
 
+        if (version_compare(PHP_VERSION, '8.3.0', '>=')) {
+            $I->markTestSkipped('Invalid `unserialize()` will generate warning but still works.');
+        }
+
         $serializer = new SerializerFactory();
         $adapter    = new Stream(
             $serializer,

diff --git a/tests/integration/Storage/Serializer/ExceptionsCest.php b/tests/integration/Storage/Serializer/ExceptionsCest.php
@@ -316,6 +316,11 @@ function () {
     public function storageSerializerPhpUnserializeError(IntegrationTester $I)
     {
         $I->wantToTest('Storage\Serializer\Php - unserialize() - error');
+
+        if (version_compare(PHP_VERSION, '8.3.0', '>=')) {
+            $I->markTestSkipped('Invalid `unserialize()` will generate warning but still works.');
+        }
+
         $serializer = new Php();
 
         $serialized = '{??hello?unserialize"';

diff --git a/tests/unit/Http/Response/GetSetStatusCodeCest.php b/tests/unit/Http/Response/GetSetStatusCodeCest.php
@@ -146,6 +146,10 @@ public function testSetStatusCodeDefaultMessage(UnitTester $I)
      */
     public function testHttpResponseSetStatusCodeSend(UnitTester $I)
     {
+        if (!function_exists('xdebug_get_headers')) {
+            $I->skipTest('xdebug extension is not installed');
+        }
+
         $response = $this->getResponseObject();
 
         $body = ['test' => 123];
@@ -180,6 +184,10 @@ public function testHttpResponseSetStatusCodeSend(UnitTester $I)
      */
     public function testHttpResponseSetStatusCodeSendMicro(UnitTester $I)
     {
+        if (!function_exists('xdebug_get_headers')) {
+            $I->skipTest('xdebug extension is not installed');
+        }
+
         $application = new Micro($this->container);
 
         $application->before(new HttpResponseContentMiddleware());