Skip to content

[GSoC-2020] Experimental Functions - pgr_depthFirstSearch, pgr_sequentialVertexColoring #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 311 commits into from
Aug 10, 2020
Merged

[GSoC-2020] Experimental Functions - pgr_depthFirstSearch, pgr_sequentialVertexColoring #1599

merged 311 commits into from
Aug 10, 2020

Conversation

krashish8
Copy link
Member

@krashish8 krashish8 commented Aug 6, 2020 •
edited
Loading

Closes #1348, #1362.

This PR adds two new pgRouting functions:

  • pgr_depthFirstSearch: Returns a depth first search traversal of the graph. The graph can be directed or undirected.
  • pgr_sequentialVertexColoring: Returns the vertex coloring of an undirected graph, using greedy approach.

This is a final merge PR containing commits from several different PRs combined.

The intermediate PRs made on the GSoC-pgRouting repository are as follows:

Description Pull Requests
pgr_depthFirstSearch
pgr_sequentialVertexColoring
Code Review & Documentation

krashish8 added 30 commits August 1, 2020 08:30
@krashish8
[depthFirstSearch] Fixed errors in pgTAP test
5966091
@krashish8
[depthFirstSearch] Added pgTAP test for multiple vertices
76eff37
@krashish8
[depthFirstSearch] Added pgTAP test for multiple vertices with depth …
4727cae 
…parameter
@krashish8
[depthFirstSearch] Fixed plan of tests for server no crash
a766289
@krashish8
[depthFirstSearch] Removed todo in no-crash-test
57a6369
@krashish8
[depthFirstSearch] Modified no crash pgTAP test
cb80369
@krashish8
[depthFirstSearch] Modified no crash test pgTAP tests
e6d1aef
@krashish8
[depthFirstSearch] Modified parameter types check
d846ead
@krashish8
[depthFirstSearch] Added inner query pgTAP tests
7873d20
@krashish8
[depthFirstSearch] Removed todo in inner query tests
f024c4a
@krashish8
[depthFirstSearch] Refactor C code
1e4a2bf
@krashish8
[depthFirstSearch] Modified hpp file
824c4de
@krashish8
[depthFirstSearch] Added some comments
1ab2bdc
@krashish8
[depthFirstSearch] Fixed indentation
b886a94
@krashish8
[depthFirstSearch] Replaced all := by => in the named notation
d15ceff
@krashish8
[depthFirstSearch] Added pgTAP unit tests for 0 edge, 0 vertex direct…
a06516c 
…ed graph
@krashish8
[depthFirstSearch] Added pgTAP unit tests for 0 edge, 0 vertex undire…
274e3a3 
…cted graph
@krashish8
[depthFirstSearch] Added pgTAP unit tests - vertex not present in dir…
c625cba 
…ected graph
@krashish8
[depthFirstSearch] Added pgTAP unit tests - vertex not present in und…
d171239 
…irected graph
@krashish8
[depthFirstSearch] Added pgTAP unit test - negative depth tests
1ad370d
@krashish8
[depthFirstSearch] Added pgtap test for single vertex directed graph
5f2552e
@krashish8
[depthFirstSearch] Added pgtap test for single vertex undirected graph
46207e2
@krashish8
[depthFirstSearch] Added pgTAP test for 2 vertices (directed)
b733845
@krashish8
[depthFirstSearch] Added pgTAP test for 2 vertices (undirected)
7913f8d
@krashish8
[depthFirstSearch] Added 3 vertices table for pgtap test
2b1c512
@krashish8
[depthFirstSearch] Added pgTAP test for 3 vertices directed graph
4927e3b
@krashish8
[depthFirstSearch] Added pgTAP test for 3 vertices undirected graph
67198ac
@krashish8
[depthFirstSearch] Changed pgTAP test numbers
afb22c4
@krashish8
[depthFirstSearch] Added prepared statement for 4 vertices graph
b397b02
@krashish8
[depthFirstSearch] Added pgTAP test for 4 vertices directed graph
e78c0e8
@krashish8 krashish8 self-assigned this Aug 6, 2020
This was linked to issues Aug 6, 2020
GSoC '20: Detailed signature and usage of the new function pgr_depthFirstSearch() to be added in pgRouting #1348
Closed
GSoC '20: Detailed signature and usage of the new function pgr_sequentialVertexColoring() to be added in pgRouting #1362
Closed
dkastl
dkastl approved these changes Aug 8, 2020
View reviewed changes
Copy link
Member

@dkastl dkastl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
This looks nice.

@krashish8 krashish8 merged commit bc86df2 into pgRouting:develop Aug 10, 2020
@cvvergara cvvergara added this to the Release 3.2.0 milestone Aug 10, 2020
@cvvergara cvvergara mentioned this pull request Dec 12, 2020
Closed
@krashish8 krashish8 added the GSoC label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkastl dkastl dkastl approved these changes

@cvvergara cvvergara cvvergara approved these changes

@cayetanobv cayetanobv cayetanobv approved these changes

+1 more reviewer

@AasheeshT AasheeshT AasheeshT approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@krashish8 krashish8

Labels
coloring Functionality/experimental Functionality/New GSoC traversal
Projects
None yet
Milestone
Release 3.2.0
5 participants
@krashish8 @dkastl @cvvergara @AasheeshT @cayetanobv