feat: implement issue #1306 — [bmad-onboard P1] Vendor bmad-bgreat-suite into frameworks/ - #1310
Conversation
…ite into frameworks/
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedToo many files! This PR contains 115 files, which is 15 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (115)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-07-18T18:57:04Z. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
There was a problem hiding this comment.
Pull request overview
This pull request vendors the petry-projects/bmad-bgreat-suite framework into this repo under frameworks/bmad-bgreat-suite/, aligning with the existing “vendored framework under frameworks/ + VENDOR.md pin” pattern used for other BMAD subtrees.
Changes:
- Added
frameworks/bmad-bgreat-suite/vendored tree (agents, workflows, skills, templates, module metadata) plus MITLICENSE. - Added
frameworks/bmad-bgreat-suite/VENDOR.mdpinning the upstream commitae8914e84b87and documenting theframeworks/bmad-method/dependency. - Introduced the module catalog (
src/module.yaml,src/module-help.csv) to expose the agents/workflows/skill.
Reviewed changes
Copilot reviewed 116 out of 116 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frameworks/bmad-bgreat-suite/LICENSE | Vendored upstream license. |
| frameworks/bmad-bgreat-suite/VENDOR.md | Vendoring metadata + pinned commit + refresh instructions. |
| frameworks/bmad-bgreat-suite/src/agents/bgr-agent-morgan-sre/SKILL.md | Morgan agent definition (SRE Lead persona). |
| frameworks/bmad-bgreat-suite/src/agents/bgr-agent-morgan-sre/bmad-skill-manifest.yaml | Morgan agent manifest metadata. |
| frameworks/bmad-bgreat-suite/src/agents/bgr-agent-riley-devops/SKILL.md | Riley agent definition (DevOps Lead persona). |
| frameworks/bmad-bgreat-suite/src/agents/bgr-agent-riley-devops/bmad-skill-manifest.yaml | Riley agent manifest metadata. |
| frameworks/bmad-bgreat-suite/src/agents/bgr-agent-sam-security/SKILL.md | Sam agent definition (Security Lead persona). |
| frameworks/bmad-bgreat-suite/src/agents/bgr-agent-sam-security/bmad-skill-manifest.yaml | Sam agent manifest metadata. |
| frameworks/bmad-bgreat-suite/src/module-help.csv | Module skill catalog used for menus/sequencing/output discovery. |
| frameworks/bmad-bgreat-suite/src/module.yaml | Module configuration (variables, directories, post-install notes). |
| frameworks/bmad-bgreat-suite/src/skills/bgr-ops-review/SKILL.md | Ops review skill instructions (cross-artifact lint/review). |
| frameworks/bmad-bgreat-suite/src/skills/bgr-ops-review/bmad-skill-manifest.yaml | Ops review skill manifest metadata. |
| frameworks/bmad-bgreat-suite/src/skills/bgr-ops-review/templates/ops-review-report.md | Ops review report template. |
| frameworks/bmad-bgreat-suite/src/templates/bgr-production-readiness-checklist-template.md | Production readiness checklist template shared across workflows. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-capacity-plan/SKILL.md | Capacity plan workflow skill entrypoint. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-capacity-plan/bmad-skill-manifest.yaml | Capacity plan workflow manifest metadata. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-capacity-plan/templates/capacity-plan-template.md | Capacity plan output template. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-capacity-plan/workflow.md | Capacity plan workflow top-level orchestration. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-capacity-plan/steps/step-01-init.md | Capacity plan initialization step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-capacity-plan/steps/step-01b-continue.md | Capacity plan continuation/resume step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-capacity-plan/steps/step-02-growth-modeling.md | Capacity plan growth modeling step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-capacity-plan/steps/step-03-scaling-strategy.md | Capacity plan scaling strategy step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-capacity-plan/steps/step-04-validation-testing.md | Capacity plan validation/testing step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-capacity-plan/steps/step-05-validation.md | Capacity plan final validation step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-chaos-gameday-plan/SKILL.md | Chaos game day plan workflow skill entrypoint. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-chaos-gameday-plan/bmad-skill-manifest.yaml | Chaos game day plan workflow manifest metadata. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-chaos-gameday-plan/templates/chaos-gameday-plan-template.md | Chaos game day plan output template. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-chaos-gameday-plan/workflow.md | Chaos game day plan workflow top-level orchestration. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-chaos-gameday-plan/steps/step-01-init.md | Chaos game day plan initialization step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-chaos-gameday-plan/steps/step-01b-continue.md | Chaos game day plan continuation/resume step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-chaos-gameday-plan/steps/step-02-hypothesis-design.md | Chaos game day hypothesis design step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-chaos-gameday-plan/steps/step-03-blast-radius-safety.md | Chaos game day blast radius/safety step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-chaos-gameday-plan/steps/step-04-execution-observation.md | Chaos game day execution/observation step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-chaos-gameday-plan/steps/step-05-validation.md | Chaos game day final validation step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-cost-optimization-plan/SKILL.md | Cost optimization workflow skill entrypoint. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-cost-optimization-plan/bmad-skill-manifest.yaml | Cost optimization workflow manifest metadata. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-cost-optimization-plan/templates/cost-optimization-plan-template.md | Cost optimization output template. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-cost-optimization-plan/workflow.md | Cost optimization workflow top-level orchestration. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-cost-optimization-plan/steps/step-01-init.md | Cost optimization initialization step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-cost-optimization-plan/steps/step-01b-continue.md | Cost optimization continuation/resume step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-cost-optimization-plan/steps/step-02-cost-baseline.md | Cost optimization baseline step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-cost-optimization-plan/steps/step-03-optimization-strategy.md | Cost optimization strategy step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-cost-optimization-plan/steps/step-04-governance.md | Cost optimization governance step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-cost-optimization-plan/steps/step-05-validation.md | Cost optimization final validation step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-disaster-recovery/SKILL.md | Disaster recovery workflow skill entrypoint. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-disaster-recovery/bmad-skill-manifest.yaml | Disaster recovery workflow manifest metadata. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-disaster-recovery/templates/disaster-recovery-plan-template.md | Disaster recovery plan output template. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-disaster-recovery/workflow.md | Disaster recovery workflow top-level orchestration. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-disaster-recovery/steps/step-01-init.md | Disaster recovery initialization step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-disaster-recovery/steps/step-01b-continue.md | Disaster recovery continuation/resume step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-disaster-recovery/steps/step-02-rto-rpo-analysis.md | Disaster recovery RTO/RPO analysis step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-disaster-recovery/steps/step-03-backup-restore-strategy.md | Disaster recovery backup/restore strategy step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-disaster-recovery/steps/step-04-failover-procedures.md | Disaster recovery failover procedures step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-disaster-recovery/steps/step-05-validation.md | Disaster recovery final validation step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-incident-response/SKILL.md | Incident response workflow skill entrypoint. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-incident-response/bmad-skill-manifest.yaml | Incident response workflow manifest metadata. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-incident-response/templates/incident-response-plan-template.md | Incident response plan output template. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-incident-response/templates/postmortem-template.md | Postmortem template. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-incident-response/templates/runbook-template.md | Runbook template. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-incident-response/workflow.md | Incident response workflow top-level orchestration. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-incident-response/steps/step-01-init.md | Incident response initialization step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-incident-response/steps/step-01b-continue.md | Incident response continuation/resume step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-incident-response/steps/step-02-severity-classification.md | Incident response severity classification step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-incident-response/steps/step-03-response-procedures.md | Incident response procedures step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-incident-response/steps/step-04-runbooks-postmortems.md | Incident response runbooks/postmortems step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-incident-response/steps/step-05-validation.md | Incident response final validation step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-infrastructure/SKILL.md | Infrastructure workflow skill entrypoint. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-infrastructure/bmad-skill-manifest.yaml | Infrastructure workflow manifest metadata. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-infrastructure/templates/infrastructure-template.md | Infrastructure plan output template. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-infrastructure/workflow.md | Infrastructure workflow top-level orchestration. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-infrastructure/steps/step-01-init.md | Infrastructure initialization step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-infrastructure/steps/step-01b-continue.md | Infrastructure continuation/resume step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-infrastructure/steps/step-02-iac-strategy.md | Infrastructure IaC strategy step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-infrastructure/steps/step-03-environment-strategy.md | Infrastructure environment strategy step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-infrastructure/steps/step-04-container-strategy.md | Infrastructure container strategy step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-infrastructure/steps/step-05-validation.md | Infrastructure final validation step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-observability/SKILL.md | Observability workflow skill entrypoint. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-observability/bmad-skill-manifest.yaml | Observability workflow manifest metadata. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-observability/templates/observability-plan-template.md | Observability plan output template. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-observability/workflow.md | Observability workflow top-level orchestration. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-observability/steps/step-01-init.md | Observability initialization step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-observability/steps/step-01b-continue.md | Observability continuation/resume step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-observability/steps/step-02-current-state.md | Observability current-state assessment step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-observability/steps/step-03-design-instrumentation.md | Observability instrumentation design step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-observability/steps/step-04-slo-alert-framework.md | Observability SLO/alerting framework step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-observability/steps/step-05-validation.md | Observability final validation step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-pipeline/SKILL.md | CI/CD pipeline workflow skill entrypoint. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-pipeline/bmad-skill-manifest.yaml | CI/CD pipeline workflow manifest metadata. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-pipeline/templates/pipeline-template.md | Pipeline plan output template. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-pipeline/workflow.md | Pipeline workflow top-level orchestration. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-pipeline/steps/step-01-init.md | Pipeline initialization step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-pipeline/steps/step-01b-continue.md | Pipeline continuation/resume step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-pipeline/steps/step-02-pipeline-architecture.md | Pipeline architecture step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-pipeline/steps/step-03-pipeline-stages.md | Pipeline stages step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-pipeline/steps/step-04-deployment-strategy.md | Pipeline deployment strategy step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-pipeline/steps/step-05-validation.md | Pipeline final validation step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-resilience-plan/SKILL.md | Resilience testing workflow skill entrypoint. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-resilience-plan/bmad-skill-manifest.yaml | Resilience testing workflow manifest metadata. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-resilience-plan/templates/resilience-plan-template.md | Resilience testing plan output template. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-resilience-plan/workflow.md | Resilience testing workflow top-level orchestration. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-resilience-plan/steps/step-01-init.md | Resilience testing initialization step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-resilience-plan/steps/step-01b-continue.md | Resilience testing continuation/resume step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-resilience-plan/steps/step-02-steady-state.md | Resilience testing steady-state hypotheses step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-resilience-plan/steps/step-03-failure-scenarios.md | Resilience testing failure scenarios step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-resilience-plan/steps/step-04-game-day-planning.md | Resilience testing game day planning step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-resilience-plan/steps/step-05-validation.md | Resilience testing final validation step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-security-plan/SKILL.md | Security plan workflow skill entrypoint. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-security-plan/bmad-skill-manifest.yaml | Security plan workflow manifest metadata. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-security-plan/templates/security-plan-template.md | Security plan output template. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-security-plan/workflow.md | Security plan workflow top-level orchestration. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-security-plan/steps/step-01-init.md | Security plan initialization step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-security-plan/steps/step-01b-continue.md | Security plan continuation/resume step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-security-plan/steps/step-02-threat-modeling.md | Security plan threat modeling step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-security-plan/steps/step-03-security-controls.md | Security plan security controls step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-security-plan/steps/step-04-compliance-mapping.md | Security plan compliance mapping step. |
| frameworks/bmad-bgreat-suite/src/workflows/bgr-3-create-security-plan/steps/step-05-validation.md | Security plan final validation step. |
There was a problem hiding this comment.
Code Review
This pull request introduces the BMad BGreat Suite, adding specialized SRE, DevOps, and Security agents along with guided workflows for production readiness (including capacity, chaos game days, cost optimization, disaster recovery, incident response, infrastructure, observability, and pipelines). The review feedback highlights several copy-paste errors and inconsistencies in the validation steps of these workflows. Specifically, the Disaster Recovery Plan validation included checks copied from the Capacity Plan, multiple validation files incorrectly referenced 'all 7 workflows' instead of 'all 8 workflows', and some checks looked for a status of 'complete' instead of 'approved' for the Infrastructure Plan.
Dev-Lead — fix-reviews (applied)Changes committed and pushed. |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
|
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
Superseded by automated re-review at
|
Review — fix requested (cycle 2/3)The automated review identified the following issues. Please address each one: Findings to fixAutomated review — NEEDS HUMAN REVIEWRisk: MEDIUM SummaryPR #1310 vendors the bmad-bgreat-suite framework: 116 files, all pure content (84 .md, 14 .yaml, 1 .csv, LICENSE) under frameworks/bmad-bgreat-suite/ — no executable code, shell scripts, GitHub Actions workflows, auth/secrets, or DB migrations, so there is no security surface (all CI green: gitleaks, CodeQL, Agent Security Scan, SonarCloud Quality Gate passed with 0 new issues; run_secret_scanning MCP tool was not available and gitleaks covered the secret gate). However, the triage escalation trigger is confirmed real: the Disaster Recovery validation step (bgr-3-create-disaster-recovery/steps/step-05-validation.md) contains copy-paste errors where cross-plan dependency and coherence checks reference Capacity-Plan concerns (scaling strategies, capacity alerts, load testing, capacity reserves) instead of DR-specific dependencies, plus workflow-count inconsistencies (7 vs 8) in four validation files and an approved-vs-complete mismatch. Downstream impact: (none). No security concern, so no Tier 3 audit needed — escalating for human resolution of the confirmed MEDIUM content defects before merge. Findings
Reviewed by the PR-review cascade (triage: haiku 4.5 → deep: opus 4.8 + duck: o4-mini → audit: fable 5). Reply if you need a human review. Additional tasks
The review cascade will automatically re-review after new commits are pushed. |
|
Validated the escalation: Gemini's findings (copy-paste errors in the DR-plan validation, workflow-count 7-vs-8) are in files that are byte-identical to upstream |
|
Admin-merging (disclosed). Validated as the shepherd:
Human verification (what the escalation asked for) is done. Merging to unblock the Epic #1304 DAG (S1–S3 depend on this). |



Closes #1306
Implemented by dev-lead agent. Please review.