[bmad-onboard P1] Vendor bmad-bgreat-suite into frameworks/

[don-petry]

Part of Epic #1304 (onboard the bmad-bgreat-suite ops personas). Root prerequisite — blocks S1/S2/S3.

Task

Vendor petry-projects/bmad-bgreat-suite into frameworks/bmad-bgreat-suite/, matching how bmad-method and bmad-test-architecture are vendored (git subtree).

• Add frameworks/bmad-bgreat-suite/VENDOR.md pinning commit ae8914e84b87 — the suite has no tags, so pin a SHA (not a version). Follow the shape of frameworks/bmad-test-architecture/VENDOR.md (source repo, pinned ref, refresh note).
• Vendor the three agents and their workflows: src/agents/bgr-agent-{morgan-sre,riley-devops,sam-security}, src/skills/, src/workflows/.
• The agents reference bmad-method skills — confirm that dependency resolves against the already-vendored frameworks/bmad-method/ (do not re-vendor bmad-method).
• Never hand-edit vendored files (§2 / VENDOR discipline).

Constraints

• AgentShield must pass on the vendored tree.
• .github-private is PUBLIC — no auth assumptions needed for anything reading these files.
• This is a vendoring PR only: no manifests, no persona wiring (that is S1–S3).

Files/refs

• frameworks/bmad-test-architecture/VENDOR.md — the VENDOR.md shape to copy.
• Source: https://github.com/petry-projects/bmad-bgreat-suite @ ae8914e84b87.

Acceptance criteria

• frameworks/bmad-bgreat-suite/ exists with the three agents + workflows + skills.
• frameworks/bmad-bgreat-suite/VENDOR.md pins commit ae8914e84b87 with source + refresh note.
• The bmad-method dependency is satisfied by the existing vendored copy (documented, not re-vendored).
• AgentShield passes.

Blocks: S1 (sre-lead), S2 (devops-lead), S3 (security-lead). Epic: #1304.

[github-actions]

Thanks for the detailed issue and for mapping out the dependency chain so clearly! To make sure the vendoring lands cleanly: is the ae8914e84b87 commit on the default branch of petry-projects/bmad-bgreat-suite, or do we need to target a specific branch when running the git subtree add?

[don-petry]

Yes — ae8914e84b87 is on the default branch (main) of petry-projects/bmad-bgreat-suite; I pinned it from commits/main. No special branch targeting needed: git subtree add --prefix frameworks/bmad-bgreat-suite https://github.com/petry-projects/bmad-bgreat-suite.git ae8914e84b87 --squash (or the repo's established subtree-vendoring approach — match how frameworks/bmad-test-architecture was brought in). Please proceed.

[don-petry]

Dev-Lead Implementation Plan

Issue: #1306 — [bmad-onboard P1] Vendor bmad-bgreat-suite into frameworks/

Scope

Vendor petry-projects/bmad-bgreat-suite @ ae8914e84b87 into frameworks/bmad-bgreat-suite/, matching the existing git-subtree/clone-copy pattern of bmad-method and bmad-test-architecture (whole src/ + LICENSE + VENDOR.md). Vendoring only — no manifests or persona wiring (that is S1–S3).

Implementation Checklist

• Create frameworks/bmad-bgreat-suite/src/ as a verbatim copy of upstream src/ @ ae8914e84b87 (three agents bgr-agent-{morgan-sre,riley-devops,sam-security}, skills/, workflows/, plus templates/, module.yaml, module-help.csv — the whole src/, so Refresh reproduces it byte-for-byte)
• Copy upstream LICENSE → frameworks/bmad-bgreat-suite/LICENSE
• Write frameworks/bmad-bgreat-suite/VENDOR.md pinning commit ae8914e84b87 (SHA, not a tag — suite has no tags), following frameworks/bmad-test-architecture/VENDOR.md shape (source repo, pinned ref, refresh note), and documenting that the bmad-method skill dependency (agents reference the bmad-help skill) resolves against the already-vendored frameworks/bmad-method/ — not re-vendored

Tests to Write

• None. This is a pure vendoring PR (verbatim upstream copy + docs/config), matching the two existing vendored frameworks, neither of which carries a dedicated test. TDD Phase 2 skipped per the prompt's documentation/configuration exception. Verification is structural (files present, VENDOR.md pins the SHA) plus the dev-lead lint + AgentShield gates.

Test Command

bash .dev-lead/scripts/dev-lead-lint.sh (repo lint gate; AgentShield runs in CI)

[don-petry]

Dev-Lead: Implementation Complete

Plan Execution

• Vendored upstream src/ @ ae8914e84b87 verbatim into frameworks/bmad-bgreat-suite/src/ (114 files, byte-identical to source — diff -r clean)
• Copied upstream LICENSE (MIT) into frameworks/bmad-bgreat-suite/LICENSE
• Wrote frameworks/bmad-bgreat-suite/VENDOR.md pinning commit ae8914e84b87 (SHA, not a tag) with source + refresh note, following the bmad-test-architecture/VENDOR.md shape
• Documented that the bmad-method skill dependency (agents invoke the bmad-help skill) resolves against the already-vendored frameworks/bmad-method/src/core-skills/bmad-help/ — not re-vendored

Test Results

$ bash .dev-lead/scripts/dev-lead-lint.sh
  [lint] shellcheck on 94 file(s)...
  [lint] validating 4 agent profile(s)...
OK: agents/agentic-workflows.md
OK: agents/compliance-auditor.md
OK: agents/feature-ideator.md
OK: agents/pr-reviewer.md
  [lint] validating .github/CODEOWNERS...
OK: .github/CODEOWNERS
  [lint] all checks passed

Verification (structural):
- src byte-identity vs upstream @ ae8914e84b87: IDENTICAL (diff -r clean, 114/114 files)
- LICENSE byte-identity: IDENTICAL
- bmad-help dependency present at frameworks/bmad-method/src/core-skills/bmad-help/: yes
- all changes scoped to frameworks/bmad-bgreat-suite/ (no unrelated files touched)

Files Changed

• frameworks/bmad-bgreat-suite/VENDOR.md (new): pins ae8914e84b87, source, refresh recipe, bmad-method dependency note
• frameworks/bmad-bgreat-suite/LICENSE (new): upstream MIT license, verbatim
• frameworks/bmad-bgreat-suite/src/** (new, 114 files): verbatim upstream copy — 3 agents (bgr-agent-{morgan-sre,riley-devops,sam-security}), skills/bgr-ops-review, 10 workflows/, templates/, module.yaml, module-help.csv

Acceptance Criteria

• frameworks/bmad-bgreat-suite/ exists with the three agents + workflows + skills
• VENDOR.md pins commit ae8914e84b87 with source + refresh note
• bmad-method dependency satisfied by existing vendored copy (documented, not re-vendored)
• AgentShield — runs in CI on this PR; local dev-lead lint passes

Notes

• Whole-src/ copy (deliberate): the whole upstream src/ is vendored — including module.yaml, module-help.csv, and templates/ alongside the issue's explicitly-listed agents/, skills/, workflows/. This matches both existing vendored frameworks (bmad-method, bmad-test-architecture) and keeps the Refresh recipe (cp -r .../src .../src) reproducing the committed tree byte-for-byte. Vendoring only the three named subdirs would drift on refresh, violating VENDOR discipline.
• TDD Phase 2 skipped per the prompt's documentation/configuration exception: this is a verbatim upstream copy plus VENDOR.md/LICENSE docs, with no first-party code to test — consistent with the two existing vendored frameworks, neither of which carries a dedicated test. Verification is structural (byte-identity + presence) plus the lint/AgentShield gates.
• No hand-edits to any vendored file (§2 / VENDOR discipline).
• This is a vendoring PR only — no manifests, no persona wiring (that is S1–S3 under epic Epic: Onboard the bmad-bgreat-suite ops personas (sre-lead, devops-lead, security-lead) #1304).