Skip to content

[ENHANCEMENT] StatChart: improve Grafana migration#281

Merged
AntoineThebaud merged 3 commits intomainfrom
antoinethebaud/statchart-mig
Aug 29, 2025
Merged

[ENHANCEMENT] StatChart: improve Grafana migration#281
AntoineThebaud merged 3 commits intomainfrom
antoinethebaud/statchart-mig

Conversation

@AntoineThebaud
Copy link
Contributor

@AntoineThebaud AntoineThebaud commented Aug 28, 2025

Description

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud AntoineThebaud force-pushed the antoinethebaud/statchart-mig branch from 6fffe7a to f988705 Compare August 28, 2025 09:12
@AntoineThebaud AntoineThebaud marked this pull request as ready for review August 28, 2025 09:24
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. If @abelyakin you are able to provide an example, we can still iterate based on that to make the migration script stronger.

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud AntoineThebaud force-pushed the antoinethebaud/statchart-mig branch from 53b98ce to e5d6d4b Compare August 29, 2025 13:46
@AntoineThebaud AntoineThebaud added this pull request to the merge queue Aug 29, 2025
Merged via the queue into main with commit fb1986e Aug 29, 2025
13 checks passed
@AntoineThebaud AntoineThebaud deleted the antoinethebaud/statchart-mig branch August 29, 2025 13:56
@ibakshay
Copy link
Contributor

@AntoineThebaud , @Nexucis Shall we also add this PR as part of v0.52..0 release?

rafi-ruetcse17 pushed a commit to opnpulse/perses_plugins that referenced this pull request Sep 1, 2025
* [ENHANCEMENT] StatChart: improve Grafana migration

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* Remove useless interpolation

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* support 2 modes of migrating metricLabel

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

---------

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud
Copy link
Contributor Author

@ibakshay it was too late to be taken in v0.52.0-rc.0 but it should be part of the final v0.52.0 yes

abelyakin pushed a commit to abelyakin/plugins that referenced this pull request Jan 14, 2026
* [ENHANCEMENT] StatChart: improve Grafana migration

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* Remove useless interpolation

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* support 2 modes of migrating metricLabel

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

---------

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants