Merged
Conversation
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
AntoineThebaud
changed the title
AntoineThebaud
changed the title
Nexucis
reviewed
Aug 26, 2025
| colorMode: "fixed" | ||
| colorValue: property.value.fixedColor | ||
| } | ||
| if override.matcher.id == "byName" && override.matcher.options != _|_ |
Member
There was a problem hiding this comment.
would have been great to keep the indentation, the code is harder to read now
Contributor
Author
There was a problem hiding this comment.
It's more correct like this because all the for & if are chained here (notice that there's no opening brace at the end of each line), so this doesnt mislead you in thinking we are generating structs in the middle of the chain. Actually if we were enforcing file formatting I think that would be the output since this is what I get on CUE playground:
3 tasks
rafi-ruetcse17
pushed a commit
to opnpulse/perses_plugins
that referenced
this pull request
Sep 1, 2025
* [IGNORE] Table migration: small refacto & add note for future work Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr> * avoid empty array for querySettings + formatting Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr> --------- Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
abelyakin
pushed a commit
to abelyakin/plugins
that referenced
this pull request
Jan 14, 2026
* [IGNORE] Table migration: small refacto & add note for future work Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr> * avoid empty array for querySettings + formatting Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr> --------- Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.