Incremental annotation processing for Kotlin #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technoir42
force-pushed
the
incremental-kapt
branch
from
d8308c2 to
f020557
Compare
|
👀 |
hotchemi
reviewed
Jun 18, 2019
|
|
||
| private fun createWithPermissionCheckFun(rpe: RuntimePermissionsElement, method: ExecutableElement): FunSpec { | ||
| val builder = FunSpec.builder(withPermissionCheckMethodName(method)) | ||
| .addOriginatingElement(rpe.element) |
There was a problem hiding this comment.
Do we need to add an original element for every spec builder?👀
There was a problem hiding this comment.
It might work if we set an origin element for just one spec that's guaranteed to be present in the file. But I think it's better to be safe and explicit and set origin element for every top-level spec we produce.
KotlinPoet 1.3.0+ deduplicates origin elements before passing them to Filer so kapt will see only one origin element.
| // FIXME: weirdly under kaptKotlin files is not recognized as source file on AS or IntelliJ | ||
| // so as a workaround we generate .kt file in generated/source/kapt/$sourceSetName | ||
| // ref: https://github.com/hotchemi/PermissionsDispatcher/issues/320#issuecomment-316175775 | ||
| val kaptGeneratedDirPath = processingEnv.options[KAPT_KOTLIN_GENERATED_OPTION_NAME]?.replace("kaptKotlin", "kapt") |
There was a problem hiding this comment.
Not sure the issue has been already resolved or not👀
https://youtrack.jetbrains.com/issue/KT-20269
There was a problem hiding this comment.
Yes, that was fixed.
technoir42
force-pushed
the
incremental-kapt
branch
from
f020557 to
c4a6478
Compare
hotchemi
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #625, permissions-dispatcher/kompile-testing#13
Will add some tests later.