Update Gradle, AGP, Kotlin and KotlinPoet #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mannodermaus
approved these changes
Jun 12, 2019
hotchemi
approved these changes
Jun 12, 2019
| @@ -4,7 +4,6 @@ apply plugin: 'kotlin-kapt' | |||
|
|
|||
| android { | |||
| compileSdkVersion COMPILE_SDK_VERSION | |||
| buildToolsVersion BUILD_TOOLS_VERSION | |||
There was a problem hiding this comment.
Setting buildToolsVersion has been optional since 3.0.0. I removed it so we don't have to update it manually anymore.
I can revert this if you prefer to set buildToolsVersion explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping some versions before incremental apt. We'll need KotlinPoet 1.3.0 for sure which requires the most of these changes.
I decided not to update Gradle to 5.x for now because it might break artifact uploads.