PMM-4145 Add RDS disable metrics checkboxes.

[askomorokhov]

https://jira.percona.com/browse/PMM-4145

Ref:

• PMM-4145 Add dissable metric collection flags to RDS. pmm#500
• PMM-4145 Add flags disable metric collection. Update gRPC. pmm-managed#342
• PMM-4145 Add RDS disable metrics checkboxes. #629
• PMM-4145 Add RDS disable metric collection. rds_exporter#41
• PMM-4145 RDS disable metrics flags. pmm-admin#96
• PMM-4145 Add simple test disable RDS metrics collection. Percona-Lab/pmm-api-tests#84

FB:

• PMM-4145 RDS Disable Metric Collection Percona-Lab/pmm-submodules#772

[lunaticusgreen]

LGTM

[codecov]

Codecov Report

Merging #629 into PMM-2.0 will decrease coverage by 0.06%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           PMM-2.0     #629      +/-   ##
===========================================
- Coverage    34.08%   34.01%   -0.07%     
===========================================
  Files           39       39              
  Lines         1018     1020       +2     
  Branches       139      140       +1     
===========================================
  Hits           347      347              
- Misses         643      645       +2     
  Partials        28       28              

Impacted Files	Coverage Δ
...ddInstance/AddRemoteInstance/AddRemoteInstance.tsx	27.38% <33.33%> (-0.67%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 505bdae...25978a3. Read the comment docs.

[BupycHuk]

These fields will be shown for all MySQL Remote services, not only for RDS.

[BupycHuk]

What do you think about this? @lunaticusgreen

Suggested change

	if (remoteInstanceCredentials.isRDS) {
	return (
	<>
	<CheckboxField form={form} label={'Use performance schema'} name="qan_mysql_perfschema" />
	<span className="description"></span>
	(remoteInstanceCredentials.isRDS ? (
	<CheckboxField form={form} label={'Disable Basic Metrics'} name="disable_basic_metrics" />
	<span className="description"></span>
	<CheckboxField form={form} label={'Disable Enhanced Metrics'} name="disable_enhanced_metrics" />
	<span className="description"></span>
	) : (Null))
	</>
	);

[ademidoff]

@BupycHuk
There is no such thing as (Null) in js. What dit you mean?

[lunaticusgreen]

It looks ok, but instead of Null you have to use null

[BupycHuk]

null

[AlekSi]

CI fails hard

[AlekSi]

@BupycHuk @atymchuk Why do we update code there by hands, and don't use code generated from Swagger spec?

[ademidoff]

@BupycHuk @atymchuk Why do we update code there by hands, and don't use code generated from Swagger spec?

@AlekSi Try to be explicit: it's very hard to guess without clear pointers to the code.

[BupycHuk]

I think @lunaticusgreen should know answer

[AlekSi]

Try to be explicit: it's very hard to guess without clear pointers to the code.

Well, I can't give you a clear pointer to the absence something. :) Here is a Swagger spec: https://github.com/percona/pmm/blob/PMM-2.0/api/swagger/swagger.json We generate code from it and use that generated code – but not in that PR. Why?