Skip to content

PMM-4145 Add submodules for RDS disable metrics collection. #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

PMM-4145 Add submodules for RDS disable metrics collection. #750

wants to merge 11 commits into from

Conversation

@askomorokhov
Copy link
Contributor

@askomorokhov askomorokhov commented Mar 12, 2020 •
edited
Loading

@askomorokhov askomorokhov requested a review from AlekSi March 12, 2020 08:15
This was referenced Mar 12, 2020
Merged
Merged
Merged
Merged
Merged
AlekSi
AlekSi suggested changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not how feature builds work…

@askomorokhov askomorokhov mentioned this pull request Mar 12, 2020
Merged
7 tasks
@AlekSi AlekSi force-pushed the PMM-4145-rds-disable-metric-collection-2 branch from 3a6bb94 to 1c07d5a Compare March 19, 2020 18:05
@Percona-Lab Percona-Lab deleted a comment from JNKPercona Mar 19, 2020
@Percona-Lab Percona-Lab deleted a comment from JNKPercona Mar 19, 2020
@Percona-Lab Percona-Lab deleted a comment from JNKPercona Mar 19, 2020
@Percona-Lab Percona-Lab deleted a comment from JNKPercona Mar 19, 2020
@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-750-1c07d5a
client docker - perconalab/pmm-client-fb:PR-750-1c07d5a
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-750-1c07d5a.tar.gz

AlekSi
AlekSi suggested changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API tests are not added

@askomorokhov
PMM-4145 dd pmm-api-tests
41293ad
@askomorokhov
Merge branch 'PMM-4145-rds-disable-metric-collection-2' of github.com…
5099d27 
…:Percona-Lab/pmm-submodules into PMM-4145-rds-disable-metric-collection-2
@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-750-5099d27
client docker - perconalab/pmm-client-fb:PR-750-5099d27
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-750-5099d27.tar.gz

2 similar comments
@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-750-5099d27
client docker - perconalab/pmm-client-fb:PR-750-5099d27
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-750-5099d27.tar.gz

@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-750-5099d27
client docker - perconalab/pmm-client-fb:PR-750-5099d27
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-750-5099d27.tar.gz

@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-750-b85a513
client docker - perconalab/pmm-client-fb:PR-750-b85a513
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-750-b85a513.tar.gz

2 similar comments
@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-750-b85a513
client docker - perconalab/pmm-client-fb:PR-750-b85a513
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-750-b85a513.tar.gz

@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-750-b85a513
client docker - perconalab/pmm-client-fb:PR-750-b85a513
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-750-b85a513.tar.gz

@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-750-ad93b7d
client docker - perconalab/pmm-client-fb:PR-750-ad93b7d
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-750-ad93b7d.tar.gz

2 similar comments
@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-750-ad93b7d
client docker - perconalab/pmm-client-fb:PR-750-ad93b7d
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-750-ad93b7d.tar.gz

@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-750-ad93b7d
client docker - perconalab/pmm-client-fb:PR-750-ad93b7d
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-750-ad93b7d.tar.gz

@askomorokhov askomorokhov requested review from AlekSi and Nailya March 20, 2020 14:09
@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-750-0172fc5
client docker - perconalab/pmm-client-fb:PR-750-0172fc5
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-750-0172fc5.tar.gz

@askomorokhov
Merge branch 'PMM-2.0' of github.com:Percona-Lab/pmm-submodules into …
3b24dd3 
…PMM-4145-rds-disable-metric-collection-2
@askomorokhov
Merge branch 'PMM-4145-rds-disable-metric-collection-2' of github.com…
aed8f01 
…:Percona-Lab/pmm-submodules into PMM-4145-rds-disable-metric-collection-2
@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-750-065d2b0
client docker - perconalab/pmm-client-fb:PR-750-065d2b0
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-750-065d2b0.tar.gz

@askomorokhov askomorokhov deleted the PMM-4145-rds-disable-metric-collection-2 branch March 31, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlekSi AlekSi Awaiting requested review from AlekSi

@Nailya Nailya Awaiting requested review from Nailya

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@askomorokhov @JNKPercona @AlekSi