Remove domain cache from history/workflow (uber#4846)

pedroNet4K · May 26, 2022 · 3a813e8 · 3a813e8
1 parent 471e6d1
commit 3a813e8
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 21 deletions.
diff --git a/service/history/execution/workflow.go b/service/history/execution/workflow.go
@@ -26,7 +26,6 @@ import (
 	"context"
 	"fmt"
 
-	"github.com/uber/cadence/common/cache"
 	"github.com/uber/cadence/common/cluster"
 	"github.com/uber/cadence/common/persistence"
 	"github.com/uber/cadence/common/types"
@@ -55,7 +54,6 @@ type (
 	}
 
 	workflowImpl struct {
-		domainCache     cache.DomainCache
 		clusterMetadata cluster.Metadata
 
 		ctx          context.Context
@@ -68,7 +66,6 @@ type (
 // NewWorkflow creates a new NDC workflow
 func NewWorkflow(
 	ctx context.Context,
-	domainCache cache.DomainCache,
 	clusterMetadata cluster.Metadata,
 	context Context,
 	mutableState MutableState,
@@ -77,7 +74,6 @@ func NewWorkflow(
 
 	return &workflowImpl{
 		ctx:             ctx,
-		domainCache:     domainCache,
 		clusterMetadata: clusterMetadata,
 
 		context:      context,

diff --git a/service/history/historyEngine.go b/service/history/historyEngine.go
@@ -2784,7 +2784,6 @@ func (e *historyEngineImpl) ResetWorkflowExecution(
 		request.GetRequestID(),
 		execution.NewWorkflow(
 			ctx,
-			e.shard.GetDomainCache(),
 			e.shard.GetClusterMetadata(),
 			currentContext,
 			currentMutableState,
@@ -3295,7 +3294,6 @@ func (e *historyEngineImpl) ReapplyEvents(
 					uuid.New(),
 					execution.NewWorkflow(
 						ctx,
-						e.shard.GetDomainCache(),
 						e.shard.GetClusterMetadata(),
 						wfContext,
 						mutableState,

diff --git a/service/history/ndc/branch_manager.go b/service/history/ndc/branch_manager.go
@@ -28,7 +28,6 @@ import (
 	"github.com/pborman/uuid"
 
 	"github.com/uber/cadence/common"
-	"github.com/uber/cadence/common/cache"
 	"github.com/uber/cadence/common/cluster"
 	"github.com/uber/cadence/common/log"
 	"github.com/uber/cadence/common/persistence"
@@ -53,7 +52,6 @@ type (
 
 	branchManagerImpl struct {
 		shard           shard.Context
-		domainCache     cache.DomainCache
 		clusterMetadata cluster.Metadata
 		historyV2Mgr    persistence.HistoryManager
 
@@ -74,7 +72,6 @@ func newBranchManager(
 
 	return &branchManagerImpl{
 		shard:           shard,
-		domainCache:     shard.GetDomainCache(),
 		clusterMetadata: shard.GetService().GetClusterMetadata(),
 		historyV2Mgr:    shard.GetHistoryManager(),
 
@@ -172,7 +169,6 @@ func (r *branchManagerImpl) flushBufferedEvents(
 
 	targetWorkflow := execution.NewWorkflow(
 		ctx,
-		r.domainCache,
 		r.clusterMetadata,
 		r.context,
 		r.mutableState,

diff --git a/service/history/ndc/history_replicator.go b/service/history/ndc/history_replicator.go
@@ -309,7 +309,6 @@ func (r *historyReplicatorImpl) applyStartEvents(
 		task.getEventTime(),
 		execution.NewWorkflow(
 			ctx,
-			r.domainCache,
 			r.clusterMetadata,
 			context,
 			mutableState,
@@ -410,7 +409,6 @@ func (r *historyReplicatorImpl) applyNonStartEventsToCurrentBranch(
 
 	targetWorkflow := execution.NewWorkflow(
 		ctx,
-		r.domainCache,
 		r.clusterMetadata,
 		context,
 		mutableState,
@@ -433,7 +431,6 @@ func (r *historyReplicatorImpl) applyNonStartEventsToCurrentBranch(
 
 		newWorkflow = execution.NewWorkflow(
 			ctx,
-			r.domainCache,
 			r.clusterMetadata,
 			newContext,
 			newMutableState,
@@ -517,7 +514,6 @@ func (r *historyReplicatorImpl) applyNonStartEventsToNoneCurrentBranchWithoutCon
 		task.getEventTime(),
 		execution.NewWorkflow(
 			ctx,
-			r.domainCache,
 			r.clusterMetadata,
 			context,
 			mutableState,
@@ -664,7 +660,6 @@ func (r *historyReplicatorImpl) applyNonStartEventsResetWorkflow(
 
 	targetWorkflow := execution.NewWorkflow(
 		ctx,
-		r.domainCache,
 		r.clusterMetadata,
 		context,
 		mutableState,

diff --git a/service/history/ndc/transaction_manager.go b/service/history/ndc/transaction_manager.go
@@ -29,7 +29,6 @@ import (
 	"github.com/pborman/uuid"
 
 	"github.com/uber/cadence/common"
-	"github.com/uber/cadence/common/cache"
 	"github.com/uber/cadence/common/cluster"
 	"github.com/uber/cadence/common/log"
 	"github.com/uber/cadence/common/log/tag"
@@ -146,7 +145,6 @@ type (
 
 	transactionManagerImpl struct {
 		shard            shard.Context
-		domainCache      cache.DomainCache
 		executionCache   *execution.Cache
 		clusterMetadata  cluster.Metadata
 		historyV2Manager persistence.HistoryManager
@@ -172,7 +170,6 @@ func newTransactionManager(
 
 	transactionManager := &transactionManagerImpl{
 		shard:            shard,
-		domainCache:      shard.GetDomainCache(),
 		executionCache:   executionCache,
 		clusterMetadata:  shard.GetClusterMetadata(),
 		historyV2Manager: shard.GetHistoryManager(),
@@ -457,7 +454,7 @@ func (r *transactionManagerImpl) loadNDCWorkflow(
 		release(err)
 		return nil, err
 	}
-	return execution.NewWorkflow(ctx, r.domainCache, r.clusterMetadata, context, msBuilder, release), nil
+	return execution.NewWorkflow(ctx, r.clusterMetadata, context, msBuilder, release), nil
 }
 
 func (r *transactionManagerImpl) isWorkflowCurrent(

diff --git a/service/history/reset/resetter.go b/service/history/reset/resetter.go
@@ -366,7 +366,6 @@ func (r *workflowResetterImpl) replayResetWorkflow(
 	resetContext.SetHistorySize(resetHistorySize)
 	return execution.NewWorkflow(
 		ctx,
-		r.domainCache,
 		r.clusterMetadata,
 		resetContext,
 		resetMutableState,

diff --git a/service/history/task/transfer_active_task_executor.go b/service/history/task/transfer_active_task_executor.go
@@ -1766,7 +1766,6 @@ func (t *transferActiveTaskExecutor) resetWorkflow(
 		uuid.New(),
 		execution.NewWorkflow(
 			resetCtx,
-			t.shard.GetDomainCache(),
 			t.shard.GetClusterMetadata(),
 			currentContext,
 			currentMutableState,