Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove domain cache from history/workflow #4846

Merged
merged 2 commits into from
May 26, 2022

Conversation

mantas-sidlauskas
Copy link
Contributor

@mantas-sidlauskas mantas-sidlauskas commented May 25, 2022

What changed?
Removing dependency on domain cache

Why?
This dependency is not used at all

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented May 25, 2022

Pull Request Test Coverage Report for Build 0180fbf8-77ec-41d6-9e1a-59b794552b4d

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 122 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-0.08%) to 56.797%

Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_task_refresher.go 1 73.42%
common/membership/hashring.go 2 83.54%
common/persistence/executionManager.go 2 77.57%
common/persistence/statsComputer.go 2 95.71%
service/history/execution/mutable_state_builder.go 2 69.03%
common/cache/lru.go 3 90.73%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 55.49%
common/task/fifoTaskScheduler.go 3 84.54%
service/history/task/transfer_standby_task_executor.go 4 88.46%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 8 77.95%
Totals Coverage Status
Change from base Build 0180faa6-3fb1-433f-af76-f3604b50d6ec: -0.08%
Covered Lines: 83665
Relevant Lines: 147306

💛 - Coveralls

@mantas-sidlauskas mantas-sidlauskas marked this pull request as ready for review May 25, 2022 17:22
@mantas-sidlauskas mantas-sidlauskas merged commit 3a813e8 into uber:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants