This repository has been archived by the owner on Jun 14, 2018. It is now read-only.
Maven dependency updates #86
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,6 +65,13 @@ | |
| <groupId>org.jboss.resteasy</groupId> | ||
| <artifactId>resteasy-jaxrs</artifactId> | ||
| <version>${resteasy.version}</version> | ||
| <!-- wse javax annotation classes from org.apache.tomcat:tomcat-annotations-api --> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.jboss.spec.javax.annotation</groupId> | ||
| <artifactId>jboss-annotations-api_1.2_spec</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jboss.resteasy</groupId> | ||
|
|
@@ -80,19 +87,17 @@ | |
| <groupId>org.jboss.resteasy</groupId> | ||
| <artifactId>resteasy-jettison-provider</artifactId> | ||
| </exclusion> | ||
| <exclusion> | ||
| <groupId>org.jboss.spec.javax.annotation</groupId> | ||
| <artifactId>jboss-annotations-api_1.2_spec</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jboss.resteasy</groupId> | ||
| <artifactId>resteasy-jackson2-provider</artifactId> | ||
| <version>${resteasy.version}</version> | ||
| </dependency> | ||
|
There was a problem hiding this comment. This can't be removed because it is needed for compilation time in in class ResteasyApplicationBuilder.java. As good practice, you should always have explicitly set in your pom files all dependencies you need for compilation time, instead of relying on eventual transitive dependencies. |
||
|
|
||
| <!-- Test dependencies --> | ||
| <dependency> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This, and the following exclusion too, can't be done, because you are under the assumption that Tomcat will always be present, which is not true. Spring Boot applications can use other containers, like Jetty or Undertow.