Maven dependency updates #86
Conversation
sebady
force-pushed
the
patch-sebady-dependency-updates
branch
from
f0e0dc8
to
deee722
Compare
Add exclusions for some maven dependencies to reduce duplicate classes in classpath.
sebady
force-pushed
the
patch-sebady-dependency-updates
branch
from
deee722
to
18bd9dd
Compare
There was a problem hiding this comment.
@sebady doesn't make sense to be to exclude in this project based upon how we may assemble this later with Tomcat. The exclusion should come at a higher level
|
There is already a direct tomcat dependency here via |
|
If the goal is to have this starter be agnostic of tomcat / undertow than some of these existing dependencies will need to be reworked and some should be marked as |
|
@sebady , I agree with @TexanHogman . And, regarding the comment of yours below, not, that is not the goal of this starter. The goal of this starter is to integrate RESTEasy to Spring Boot. The tomcat dependency is brought by Spring Boot itself by default, not this starter, not RESTEasy. And the reason why Spring Boot does so is because it is "opinionated", and it prefers Tomcat as its "favorite" container.
|
| </exclusions> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jboss.resteasy</groupId> | ||
| <artifactId>resteasy-jackson2-provider</artifactId> | ||
| <version>${resteasy.version}</version> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
This can't be removed because it is needed for compilation time in in class ResteasyApplicationBuilder.java. As good practice, you should always have explicitly set in your pom files all dependencies you need for compilation time, instead of relying on eventual transitive dependencies.
| @@ -65,6 +65,13 @@ | |||
| <groupId>org.jboss.resteasy</groupId> | |||
| <artifactId>resteasy-jaxrs</artifactId> | |||
| <version>${resteasy.version}</version> | |||
| <!-- wse javax annotation classes from org.apache.tomcat:tomcat-annotations-api --> | |||
There was a problem hiding this comment.
This, and the following exclusion too, can't be done, because you are under the assumption that Tomcat will always be present, which is not true. Spring Boot applications can use other containers, like Jetty or Undertow.
|
Tomcat is always present via inclusion here of spring-boot-starter-web dependency. Would you consider removing |
|
closing. See this is an alternative pr #88 |
Add exclusions for some maven dependencies to reduce duplicate
classes in classpath.