Skip to content

Rustup override workflow script#985

Closed
benalleng wants to merge 2 commits intopayjoin:masterfrom
benalleng:rustup-override-workflow-script
Closed

Rustup override workflow script#985
benalleng wants to merge 2 commits intopayjoin:masterfrom
benalleng:rustup-override-workflow-script

Conversation

@benalleng
Copy link
Collaborator

@benalleng benalleng commented Aug 21, 2025

As some may have noticed I have been slamming my head against the wall trying to get our macos workflow working past this problem https://github.com/payjoin/rust-payjoin/actions/runs/17126953983/job/48580858265#step:6:450 but I found this recent issue rust-lang/rust#145699 but that hinges on a certain version of rust being run specifically 1.90.0 which transitions this runner to a teir 2 runner. However we should be using 1.85.0, this ensures we are forcing the rust version on our script.

Pull Request Checklist

Please confirm the following before requesting review:

  • A human has reviewed every single line of this code before opening the PR (no auto-generated, unreviewed LLM/robot submissions).
  • I have read CONTRIBUTING.md and rebased my branch to produce hygienic commits.

@benalleng benalleng requested a review from spacebear21 August 21, 2025 14:55
@benalleng benalleng force-pushed the rustup-override-workflow-script branch from c876208 to 0d7c97e Compare August 21, 2025 14:57
@benalleng benalleng marked this pull request as draft August 21, 2025 15:00
@coveralls
Copy link
Collaborator

coveralls commented Aug 21, 2025

Pull Request Test Coverage Report for Build 17131127396

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.529%

Totals Coverage Status
Change from base Build 17129145427: 0.0%
Covered Lines: 7862
Relevant Lines: 9086

💛 - Coveralls

@benalleng benalleng force-pushed the rustup-override-workflow-script branch from 0d7c97e to ecf911c Compare August 21, 2025 15:07
@spacebear21
Copy link
Collaborator

Do you know when this issue originated? It didn't seem to be a problem in #876

The compilation step seemed to not be properly running with the 1.85.0
toolchain in our build script for mac.
@benalleng benalleng force-pushed the rustup-override-workflow-script branch from ecf911c to 61a5b81 Compare August 21, 2025 15:13
@benalleng
Copy link
Collaborator Author

I honestly think it started just last night, I actually got some runs past this point. https://github.com/payjoin/rust-payjoin/actions/runs/17114371915

@benalleng
Copy link
Collaborator Author

rate limited 🤦‍♂️

@spacebear21
Copy link
Collaborator

I see...

Shouldn't the github workflow ensure 1.85 is used? We shouldn't have to update the cargo commands themselves, see e.g. the payjoin/contrib scripts

@spacebear21
Copy link
Collaborator

We may need this override in dart and python files due to rust-toolchain.toml having been added recently

env:
  # Override the value from the rust-toolchain file
  # This is necessary because even though the correct toolchain
  # is explicitly specified for the rust-toolchain action,
  # rustup honors the rust-toolchain file over the default
  RUSTUP_TOOLCHAIN: ${{ matrix.rust }}

@DanGould
Copy link
Contributor

DanGould commented Aug 21, 2025

Rate limited on CI? I don't think testing python on every version and os is necessary. We can prune down to one. Have never seen it fail on one OS and we don't even have a production impl depending on python.

@benalleng
Copy link
Collaborator Author

Think we should just use python 3.12 to keep mac and linux the same?

@spacebear21
Copy link
Collaborator

Pushed a fix here #986

@benalleng
Copy link
Collaborator Author

superseded by #986

@benalleng benalleng closed this Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants