Conversation
c876208 to
0d7c97e
Compare
Pull Request Test Coverage Report for Build 17131127396Details
💛 - Coveralls |
0d7c97e to
ecf911c
Compare
|
Do you know when this issue originated? It didn't seem to be a problem in #876 |
The compilation step seemed to not be properly running with the 1.85.0 toolchain in our build script for mac.
ecf911c to
61a5b81
Compare
|
I honestly think it started just last night, I actually got some runs past this point. https://github.com/payjoin/rust-payjoin/actions/runs/17114371915 |
|
rate limited 🤦♂️ |
|
I see... Shouldn't the github workflow ensure 1.85 is used? We shouldn't have to update the cargo commands themselves, see e.g. the payjoin/contrib scripts |
|
We may need this override in dart and python files due to rust-toolchain.toml having been added recently |
|
Rate limited on CI? I don't think testing python on every version and os is necessary. We can prune down to one. Have never seen it fail on one OS and we don't even have a production impl depending on python. |
|
Think we should just use python 3.12 to keep mac and linux the same? |
|
Pushed a fix here #986 |
|
superseded by #986 |
As some may have noticed I have been slamming my head against the wall trying to get our macos workflow working past this problem https://github.com/payjoin/rust-payjoin/actions/runs/17126953983/job/48580858265#step:6:450 but I found this recent issue rust-lang/rust#145699 but that hinges on a certain version of rust being run specifically 1.90.0 which transitions this runner to a teir 2 runner. However we should be using 1.85.0, this ensures we are forcing the rust version on our script.
Pull Request Checklist
Please confirm the following before requesting review: