Merged
Conversation
Merged
Collaborator
Pull Request Test Coverage Report for Build 17085193124Details
💛 - Coveralls |
spacebear21
added a commit
that referenced
this pull request
Jul 15, 2025
This adds support for producing dart bindings with uniffi via https://github.com/Uniffi-Dart/uniffi-dart.git (pinned commit for now until official releases exist). The unit and integration tests in dart are passing. Note that the integration test is currently flaky due to issues with `testcontainers`, so the dart Github workflow is not introduced in this PR to keep CI reliably passing. #876 adds the workflow separately but should wait until the `testcontainers` issue is resolved.
spacebear21
force-pushed
the
dart-gh-workflow
branch
from
fe06e94 to
04a0cc8
Compare
Collaborator
Author
|
Unblocked by #970 |
spacebear21
force-pushed
the
dart-gh-workflow
branch
5 times, most recently
from
08094fb to
3c1117a
Compare
benalleng
reviewed
Aug 18, 2025
| on: | ||
| pull_request: | ||
| paths: | ||
| - payjoin-ffi/** |
Collaborator
There was a problem hiding this comment.
I know we reverted this back to expand and look at all changes within the ffi repo as laid out in #722 but would it maybe be worth exploring some more targeted paths like? And then do the same for the python workflows so there aren't uneeded tests
Suggested change
| - payjoin-ffi/** | |
| - payjoin-ffi/dart/** | |
| - payjoin-ffi/src/** |
Collaborator
There was a problem hiding this comment.
Or also exclusionary to cover things like build.rs changing
Suggested change
| - payjoin-ffi/** | |
| - payjoin-ffi/** | |
| - !payjoin-ffi/python/** |
Collaborator
Author
There was a problem hiding this comment.
I think the simplicity of "any payjoin-ffi change triggers CI for all FFI languages" is worth keeping to prevent issues slipping by unnoticed.
spacebear21
force-pushed
the
dart-gh-workflow
branch
2 times, most recently
from
f7966b9 to
4ef93d8
Compare
Merged
spacebear21
force-pushed
the
dart-gh-workflow
branch
3 times, most recently
from
ecc60bb to
86b1c0d
Compare
spacebear21
force-pushed
the
dart-gh-workflow
branch
from
86b1c0d to
55ced84
Compare
benalleng
approved these changes
Aug 20, 2025
Collaborator
benalleng
left a comment
benalleng
left a comment
There was a problem hiding this comment.
Ack finally a passing CI!
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Dart tests to CI and updates the READMEs for payoin-ffi. It also fixes inconsistencies in the python CI workflow, and addresses #974 by skipping integration tests on macOS as a workaround until #915 is completed.