Tests: optimize clone usage in integration tests#960
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom Aug 17, 2025
Merged
Tests: optimize clone usage in integration tests#960spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21 merged 1 commit intopayjoin:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 17013058829Details
💛 - Coveralls |
Contributor
Author
|
The Format test in CI continues to not run and this appears to be related to #956. |
Remove 16 unnecessary .clone() calls from HTTP requests, session creation, and proposal handling to improve performance. - Remove clones from url/directory/ohttp_keys parameters (9 locations) - Remove clones from HTTP request url/body parameters (6 locations) - Remove clone from proposal response handling (1 location) - Reduces total clone count from 35 to 19 (45% reduction) All tests pass locally including clippy and formatting checks.
bc1cindy
force-pushed
the
fix/ref-args-tests-402
branch
from
82a0d42 to
833137e
Compare
Contributor
Author
It was a conflict with homebrew rust! Uninstalled it and now the format test works perfectly in CI! All checks passing |
spacebear21
approved these changes
Aug 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #402 - Remove unnecessary .clone() calls from HTTP requests and proposal handling.
Remove 16 unnecessary .clone() calls from HTTP requests, session creation,
and proposal handling to improve performance.
All tests pass locally including clippy and formatting checks.