Formatting is still inconsistent despite rust-toolchain.toml

[spacebear21]

Other contributors have ran into formatting issues despite the rust-toolchain.toml enforcing the nightly toolchain. Most recently @bc1cindy confirmed that cargo fmt applies a bunch of formatting changes to the master branch despite this output of rustup show:

Default host: aarch64-apple-darwin
     rustup home:  /Users/cindyvicentino/.rustup

     installed toolchains
     --------------------
     stable-aarch64-apple-darwin (default)
     nightly-aarch64-apple-darwin (active)

     active toolchain
     ----------------
     name: nightly-aarch64-apple-darwin
     active because: overridden by '/Users/cindyvicentino/dev/rust-payjoin/rust-toolchain.toml'
     installed targets:
       aarch64-apple-darwin

I wonder if we need to be more explicit about the specific nightly version, or maybe even add a rustfmt.toml?

[zealsham]

The repo already have a rustfmt.toml file @spacebear21

[spacebear21]

Ah yes... reading is hard.

[DanGould]

I think this is best served by getting a nix flake in order #457 with one precise cargo fmt command that makes the developer environment reproducible.

ping @thebrandonlucas

[bc1cindy]

YAY! Found it!!

It was a conflict with homebrew rust! Uninstalled it and now the format test works perfectly in CI!

All checks passing in #960 🎉

[bc1cindy]

YAY! Found it!!

It was a conflict with homebrew rust! Uninstalled it and now the format test works perfectly in CI!

All checks passing in #960 🎉

All checks passing in #962 too

[spacebear21]

Nice find! Closing this issue now in favor of #457