Skip to content

Specify OHTTP gateway for opt-in respecting ohttp-relay#570

Merged
nothingmuch merged 3 commits intopayjoin:masterfrom
nothingmuch:relay-opt-in
Mar 17, 2025
Merged

Specify OHTTP gateway for opt-in respecting ohttp-relay#570
nothingmuch merged 3 commits intopayjoin:masterfrom
nothingmuch:relay-opt-in

Conversation

@nothingmuch
Copy link
Collaborator

@nothingmuch nothingmuch commented Mar 11, 2025

@coveralls
Copy link
Collaborator

coveralls commented Mar 11, 2025

Pull Request Test Coverage Report for Build 13890753480

Details

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 80.411%

Totals Coverage Status
Change from base Build 13875410498: 0.07%
Covered Lines: 4848
Relevant Lines: 6029

💛 - Coveralls

@nothingmuch nothingmuch force-pushed the relay-opt-in branch 3 times, most recently from 3ce145b to 579598b Compare March 17, 2025 00:36
Some instances of specifying the gateway as the relay were missed in payjoin#572
@nothingmuch nothingmuch force-pushed the relay-opt-in branch 3 times, most recently from 71aced7 to cde7d06 Compare March 17, 2025 03:07
payjoin-test-util's Cargo.toml now refers to the merge commit of
payjoin/ohttp-relay#58, so before the payjoin crate can be released
ohttp-relay needs to be released and this pin removed.
@nothingmuch nothingmuch marked this pull request as ready for review March 17, 2025 03:13
Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8906c76

I'll be looking out to catch those misses like the first commit on review next time

@nothingmuch nothingmuch merged commit 6ba0282 into payjoin:master Mar 17, 2025
7 checks passed
@nothingmuch nothingmuch deleted the relay-opt-in branch March 17, 2025 03:58
@spacebear21 spacebear21 mentioned this pull request Apr 1, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants