Opt-in to traffic from arbitrary relays in directory#569
Merged
nothingmuch merged 1 commit intopayjoin:masterfrom Mar 15, 2025
Merged
Opt-in to traffic from arbitrary relays in directory#569nothingmuch merged 1 commit intopayjoin:masterfrom
nothingmuch merged 1 commit intopayjoin:masterfrom
Conversation
nothingmuch
force-pushed
the
gateway-opt-in
branch
from
7f26229 to
3af9dbe
Compare
Collaborator
Pull Request Test Coverage Report for Build 13867077590Details
💛 - Coveralls |
nothingmuch
changed the title
6 tasks
nothingmuch
force-pushed
the
gateway-opt-in
branch
2 times, most recently
from
fac9ee4 to
d17bf0d
Compare
DanGould
approved these changes
Mar 11, 2025
Collaborator
Author
|
There's no more changes pending, I will merge after I've done a final round of manual testing just to be sure nothing like the -/_ confusion snuck in again this evening |
nothingmuch
force-pushed
the
gateway-opt-in
branch
2 times, most recently
from
ab5d3dc to
22c0824
Compare
nothingmuch
force-pushed
the
gateway-opt-in
branch
from
22c0824 to
b9867d1
Compare
This change signals to relays (see payjoin/ohttp-relay#58) that even if the gateway is not known to the relay, requests are still allowed for the purposes of BIP 77. Because receivers choose the directory (which is its own gateway), but senders choose the relay, before introducing this functionality it this would have been the responsibility of the sender (or more realistically their wallet vendor) to choose an appropriate relay, one that accepts requests on behalf of the receiver's chosen directory. Rationale for adding a UUID: although arguably 64 bits of randomness is more than enough, and even just the string "BIP 77" is likely to be unique and unambiguous, adding a UUID practically ensures an opt-in is really an opt-in as 128 random bits would not be repeated except intentionally. Rationale for format: we just need a set of opaque identifiers, encoding the same way as TLS ALPN does makes sense since that's well specified, binary safe, easy to parse and places readonable limits on string lengths.
nothingmuch
force-pushed
the
gateway-opt-in
branch
from
b9867d1 to
6282ffb
Compare
nothingmuch
added a commit
that referenced
this pull request
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, the payjoin directory's RFC 9540 compatible OHTTP gateway additionally opts in to receiving OHTTP requests from arbitrary relays.
See payjoin/ohttp-relay#58.
Depends on