send SIGINT instead of SIGKILL in e2e test#497
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom Jan 20, 2025
Merged
Conversation
When running a llvm-cov instrumented payjoin-cli in the e2e test, using calling .kill() on the tokio::process::Child sends a SIGKILL, which terminates the process immediately, causing the coverage measurements to not be written. The payjoin-cli resume command already has an interrupt handler, so sending SIGINT instead makes it exit gracefully.
Collaborator
Author
|
Note that Cargo-{minimal,recent}.lock are still identical after adding |
Collaborator
Pull Request Test Coverage Report for Build 12858008331Details
💛 - Coveralls |
DanGould
approved these changes
Jan 20, 2025
Contributor
DanGould
left a comment
DanGould
left a comment
There was a problem hiding this comment.
ACK Confirmed that the coveralls build for this PR now includes coverage measurement for payoin-cli. Awesome catch.
spacebear21
approved these changes
Jan 20, 2025
Collaborator
spacebear21
left a comment
spacebear21
left a comment
There was a problem hiding this comment.
One thing I noticed is that payjoin-cli v1 is not covered, which is likely due to the missing _danger-local-https in contrib/coverage.sh for the v1 llvm-cov command. This can be addressed in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running a llvm-cov instrumented payjoin-cli in the e2e test, using calling .kill() on the tokio::process::Child sends a SIGKILL, which terminates the process immediately, causing the coverage measurements to not be written.
The payjoin-cli resume command already has an interrupt handler, so sending SIGINT instead makes it exit gracefully.
Closes #494