Propagate errors when retrieving exp parameter#441
Merged
DanGould merged 2 commits intopayjoin:masterfrom Dec 14, 2024
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 12324387724Details
💛 - Coveralls |
shinghim
force-pushed
the
399-propagate-exp
branch
from
c13d401 to
8b5ea5e
Compare
DanGould
requested changes
Dec 13, 2024
Contributor
DanGould
left a comment
DanGould
left a comment
There was a problem hiding this comment.
Another banger by @shinghim ! On a roll 💥
Other than some minor suggestions, one thing that might make sense is to move the uri_ext-specific errors into that file since they require a feature gate otherwise, and they're not generally applicable to the uri module. Perhaps a follow up commit to the change could move those feature-gated errors & their related impls into? url_ext.rs
Contributor
Author
|
@DanGould yes i think moving those errors to url_ext.rs makes sense. I'll update this with the minor changes + moving the errors |
shinghim
force-pushed
the
399-propagate-exp
branch
from
8b5ea5e to
ac15891
Compare
shinghim
force-pushed
the
399-propagate-exp
branch
2 times, most recently
from
1c01ae3 to
c34f620
Compare
nothingmuch
approved these changes
Dec 13, 2024
shinghim
force-pushed
the
399-propagate-exp
branch
from
c34f620 to
4ea00db
Compare
DanGould
approved these changes
Dec 14, 2024
DanGould
added a commit
to DanGould/rust-payjoin
that referenced
this pull request
Jan 3, 2025
Summary: Take the payjoin-cli out of alpha now that the wire protocol is presumed to be stable. Changelog: - Bump payjoin to v0.22.0 with stable wire protocol - Allow mixed input scripts in v2 (payjoin#367) - Fix bug to propagate missing config parameter or argument error (payjoin#441) - Don't pause between long polling requests (payjoin#463) - Hide danger-local-https feature with _ prefix (payjoin#423)
This was referenced Jan 3, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #428 to propagate errors when retrieving the
expparameter. This is the last of the parameter getters that need an update to return aResult, so this will close #399