Hide danger-local-https feature with _ prefix#423
Merged
DanGould merged 1 commit intopayjoin:masterfrom Dec 3, 2024
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 12128875459Details
💛 - Coveralls |
Collaborator
|
nothingmuch
approved these changes
Dec 3, 2024
Collaborator
There was a problem hiding this comment.
ACK, coverall's "changed" lines are noise and presumably an analysis bug on their side? not sure what's going on there but the "new" lines clearly existed before, and unchanged the "lost coverage" lines are just attrs
manually verified that git grep '[^_]danger-local-https' has no matches as expected
DanGould
added a commit
to DanGould/rust-payjoin
that referenced
this pull request
Jan 3, 2025
Summary: Take the payjoin-cli out of alpha now that the wire protocol is presumed to be stable. Changelog: - Bump payjoin to v0.22.0 with stable wire protocol - Allow mixed input scripts in v2 (payjoin#367) - Fix bug to propagate missing config parameter or argument error (payjoin#441) - Don't pause between long polling requests (payjoin#463) - Hide danger-local-https feature with _ prefix (payjoin#423)
This was referenced Jan 3, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents it from showing up in docs.rs documentation