Test hictkpy against Python 3.13 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robomics
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial progress towards solving #84.
hictkpy builds without problems on Python 3.13, and given that we do not link to any external libraries at runtime, we could in principle build wheels for Python 3.13 and let users deal with third-party deps that do not have wheels for Python 3.13 (currently pyarrow).
However, in the remote case where pyarrow==18 public Python API changes in a way that breaks hictkpy, we would be left with a version of hictkpy that installs fine, but fails at runtime when using Python 3.13.
Thus, I think it is better to err on the safe side and ship hictkpy v1.0.0 without wheels for Python 3.13.
Then, release v1.0.1 at a later stage, when pyarrow==18 becomes available, with pre-built Python 3.13 wheels.