Improve ICE balancing #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alancing threads This is achieved by using fixed-precision arithmetic when computing the marginals using multiple threads. Explicit synchronization is no longer necessary, as we can now use atomic ints instead of double + mutex.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 84.75% 84.77% +0.02%
==========================================
Files 101 101
Lines 7319 7312 -7
==========================================
- Hits 6203 6199 -4
+ Misses 1116 1113 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make result of interaction balancing independent from the number of balancing threads
This is achieved by using fixed-precision arithmetic when computing the marginals using multiple threads.
Explicit synchronization is no longer necessary, as we can now use atomic ints instead of double + mutex.
The downside to this approach is that results are no longer identical to those of cooler.
However, practically speaking, hictk's and cooler's results are equivalent, as balancing tests show that the relative error is below 1.0e-5.
Switching to atomic operations also improved performance.
This is especially noticeable when balancing using --in-memory (~2.5x perf improvement).