Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: hictk convert: do not hang when processing .cool files with pixels with 0 interactions #379

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

robomics
Copy link
Contributor

See #378

@robomics robomics added the bug Something isn't working label Mar 21, 2025
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.14%. Comparing base (c79831b) to head (29ef792).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...ictk/hic/impl/interaction_to_block_mapper_impl.hpp 33.33% 0 Missing and 2 partials ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #379       +/-   ##
===========================================
+ Coverage   28.64%   77.14%   +48.50%     
===========================================
  Files         102      177       +75     
  Lines       13348    22813     +9465     
  Branches      830     2476     +1646     
===========================================
+ Hits         3824    17600    +13776     
+ Misses       9064     4151     -4913     
- Partials      460     1062      +602     
Flag Coverage Δ
[tests fuzzer](https://app.codecov.io/gh/paulsengroup/hictk/pull/379/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 28.55% <0.00%> (-0.10%)
[tests integration](https://app.codecov.io/gh/paulsengroup/hictk/pull/379/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 68.62% <33.33%> (?)
[tests unittests](https://app.codecov.io/gh/paulsengroup/hictk/pull/379/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 76.43% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robomics robomics merged commit ccd6ed8 into main Mar 21, 2025
88 of 89 checks passed
@robomics robomics deleted the fix/hictk-convert-hang branch March 21, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant