Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when temporary folder cannot be safely determined #210

Merged
merged 4 commits into from
Aug 17, 2024

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Aug 16, 2024

This PR introduces three changes:

  • Improve the error message issued by hictk when the path to a temporary directory cannot be safely determined
  • In case of errors, check whether the HICTK_CI env variable is defined - this is used to workaround known issues with tmp folders in the CI environment
  • Avoid raising errors when there are issues with the tmpdir detection, and this clearly won't lead to any issues (e.g. when calling hictk --help)

Closes #193

For example when calling hictk --help and friends, or when running a
subcommand that does not require access to a temporary folder.
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.12%. Comparing base (48341b4) to head (f41e476).
Report is 29 commits behind head on main.

Files Patch % Lines
src/hictk/cli/cli_balance.cpp 66.66% 2 Missing ⚠️
src/hictk/cli/cli_load.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   85.10%   85.12%   +0.02%     
==========================================
  Files         120      120              
  Lines       10332    10355      +23     
==========================================
+ Hits         8793     8815      +22     
- Misses       1539     1540       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics added the enhancement New feature or request label Aug 16, 2024
Copy link

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to squash my commit. No need to mention. ;-)

@robomics robomics merged commit d51bce9 into main Aug 17, 2024
52 of 58 checks passed
@robomics robomics deleted the feat/tmpdir-err-msg branch August 17, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants