Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address compiler warnings when compiling with MSVC #117

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

robomics
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.65%. Comparing base (082348e) to head (14aac25).
Report is 11 commits behind head on main.

Files Patch % Lines
...include/hictk/cooler/impl/file_validation_impl.hpp 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   84.66%   84.65%   -0.02%     
==========================================
  Files         114      114              
  Lines        9125     9137      +12     
==========================================
+ Hits         7726     7735       +9     
- Misses       1399     1402       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit 2dab18f into main Feb 24, 2024
49 of 50 checks passed
@robomics robomics deleted the fix/windows-builds branch February 24, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant