Add http protocol for Gitlab custom host #60
Conversation
git-open
Outdated
|
|
||
| # handle SSH protocol (links like ssh://git@gitlab.domain.com/user/repo) | ||
| giturl=${giturl/#ssh\:\/\//https://} | ||
| giturl=${giturl/#ssh\:\/\//${gitlab_protocol}://} |
There was a problem hiding this comment.
I didn't test this since my remote url use the following scheme: git@gitlab.mydomain.com:mygroup/myrepository.git
|
@paulirish I would suggest to merge #56 first, then look at this one. They do conflict with each other. |
|
@ffes As you wish! |
|
seems bad to have a source control server not on a secure connection.... |
git-open
Outdated
| @@ -93,14 +93,18 @@ else | |||
| # custom GitLab | |||
| gitlab_domain=$(git config --get gitopen.gitlab.domain) | |||
| gitlab_port=$(git config --get gitopen.gitlab.port) | |||
| gitlab_protocol=$(git config --get gitopen.gitlab.protocol) | |||
| if [ -z "$gitlab_protocol" ]; then | |||
| gitlab_protocol=http | |||
There was a problem hiding this comment.
the default should be https, no? otherwise the docs in the readme don't make sense as setting it is redudant..
|
@MartinDelille ive got good news and bad news. :) good news: i'm nearly ready to merge this PR and finally get this sorted. I'm going to attempt to revert those changes to put your branch back to normal. then I'll followup with a PR to your https branch. Once accepted we'll merge that into master here. sound good? |
This reverts commit b25190b.
|
@MartinDelille k. your |
|
And PR to finalize all this is up: https://github.com/MartinDelille/git-open/pull/1 |
Rebase to master + default gitlab to https
|
Done |
|
All set! Thanks for everyone's patterns on this! |
|
Patience* |
|
@paulirish we do run our gitlab on our LAN, but with https so could not test really test this. I will test the current master Monday, because I use git-open every day 😉 |
|
@ffes thanks! sounds good. I've just published 1.3.0 to npm which has this PR. |
* Add http protocol for Gitlab custom host * default to https * Revert "default to https" This reverts commit b25190b. * Revert "Merge branch 'master' into http" This reverts commit 18573f8, reversing changes made to 88a9e25. * Revert "Revert "Merge branch 'master' into http"" This reverts commit fa0e6d1. * Revert "Revert "default to https"" This reverts commit d754476.
No description provided.