Skip to content

Add http protocol for Gitlab custom host #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 10, 2017
Merged

Add http protocol for Gitlab custom host #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
88a9e25
Add http protocol for Gitlab custom host
MartinDelille Nov 22, 2016
18573f8
Merge branch 'master' into http
paulirish Feb 9, 2017
b25190b
default to https
paulirish Feb 9, 2017
d754476
Revert "default to https"
paulirish Feb 9, 2017
fa0e6d1
Revert "Merge branch 'master' into http"
paulirish Feb 9, 2017
14d794d
Revert "Revert "Merge branch 'master' into http""
paulirish Feb 9, 2017
080815b
Revert "Revert "default to https""
paulirish Feb 9, 2017
a0d1b04
Merge pull request #1 from paulirish/gitlabhttp-merge
MartinDelille Feb 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,12 @@ git config [--global] gitopen.gitlab.ssh.domain [value]
git config [--global] gitopen.gitlab.ssh.port [value]
```

If your Gitlab custom hosted is serving `http` you can also specify this:
```sh
# use --global to set across all repos, instead of just the local one
git config [--global] gitopen.gitlab.protocol http
```

## Related projects / alternatives

See [hub](https://github.com/github/hub) for complete GitHub opening support.
Expand Down
12 changes: 9 additions & 3 deletions git-open
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,20 @@ else
gitlab_ssh_domain=$(git config --get gitopen.gitlab.ssh.domain)
gitlab_ssh_domain=${gitlab_ssh_domain:-$gitlab_domain}
gitlab_ssh_port=$(git config --get gitopen.gitlab.ssh.port)
if [ -n "$gitlab_domain" ]; then

gitlab_protocol=$(git config --get gitopen.gitlab.protocol)
if [ -z "$gitlab_protocol" ]; then
gitlab_protocol=https
fi

if [ -n "$gitlab_domain" ]; then
if egrep -q "${gitlab_domain}|${gitlab_ssh_domain}" <<<$giturl; then

# Handle GitLab's default SSH notation (like git@gitlab.domain.com:user/repo)
giturl=${giturl/git\@${gitlab_ssh_domain}\:/https://${gitlab_domain}/}
giturl=${giturl/git\@${gitlab_ssh_domain}\:/${gitlab_protocol}://${gitlab_domain}/}

# handle SSH protocol (links like ssh://git@gitlab.domain.com/user/repo)
giturl=${giturl/#ssh\:\/\//https://}
giturl=${giturl/#ssh\:\/\//${gitlab_protocol}://}

# remove git@ from the domain
giturl=${giturl/git\@${gitlab_ssh_domain}/${gitlab_domain}/}
Expand Down