PRED-6551 Process all the criteria(not just first one) and store in the filters #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the filter creation logic in QueryHelper to process all criteria instead of just the first one.
- Iterates over all criteria key-value pairs to create filters
- Updates the filter initialization to dynamically use each operator and criterion from the criteria hash
Comments suppressed due to low confidence (1)
lib/query_helper/sql_filter.rb:24
- [nitpick] Consider renaming the block parameters 'k' and 'v' to more descriptive names, such as 'operator_code' and 'criterion', to improve clarity.
criteria.each do |k, v|
satishaher
reviewed
May 26, 2025
Contributor
satishaher
left a comment
satishaher
left a comment
There was a problem hiding this comment.
Looks good to me,
I know we are using tags on Gemfile, but it is still better to keep the version in the version.rb file as well. Could you please update it there too?
SaurabhMangaonkar
approved these changes
May 26, 2025
satishaher
approved these changes
May 26, 2025
mayank0109
added a commit
that referenced
this pull request
Jun 11, 2025
PRED-6551 Process all the criteria(not just first one) and store in the filters
mayank0109
added a commit
that referenced
this pull request
Jun 12, 2025
PRED-6551 Process all the criteria(not just first one) and store in the filters
mayank0109
added a commit
that referenced
this pull request
Jun 13, 2025
PRED-6551 Process all the criteria(not just first one) and store in the filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup story - https://app.clickup.com/t/2323726/PRED-6551