Skip to content

PRED-6551 Process all the criteria(not just first one) and store in the filters #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

PRED-6551 Process all the criteria(not just first one) and store in the filters #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
906d34f
process all the criteria(not just first one) and store in the filters
mayank0109 May 5, 2025
c7c6cbc
update query helper version
mayank0109 May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions lib/query_helper/sql_filter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,15 @@ def create_filters
raise InvalidQueryError.new("cannot filter by #{comparate_alias}") unless map

# create the filter
@filters << QueryHelper::Filter.new(
operator_code: criteria.keys.first,
criterion: criteria.values.first,
comparate: map.sql_expression,
aggregate: map.aggregate,
qualify_clause: aggregated_attribute?(comparate: map.sql_expression)
)
criteria.each do |k, v|
@filters << QueryHelper::Filter.new(
operator_code: k,
criterion: v,
comparate: map.sql_expression,
aggregate: map.aggregate,
qualify_clause: aggregated_attribute?(comparate: map.sql_expression)
)
end
end
end

Expand Down
2 changes: 1 addition & 1 deletion lib/query_helper/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
class QueryHelper
VERSION = "0.4.2"
VERSION = "0.4.3"
end