pfEmptyState for Context Views (list, card, table) #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,6 +89,9 @@ | |||
| <label class="checkbox-inline"> | |||
| <input type="checkbox" ng-model="showDisabled">Show Disabled Cards</input> | |||
| </label> | |||
| <label class="checkbox-inline"> | |||
| + <input type="checkbox" ng-model="config.itemsAvailable">Items Available</input> | |||
| + </label> | |||
| items: '=', | ||
| eventId: '@id' | ||
| }, | ||
| transclude: true, | ||
| templateUrl: 'views/cardview/card-view.html', | ||
| controller: function (pfUtils) { | ||
| controller: function (pfUtils, $log) { |
There was a problem hiding this comment.
is $log used anywhere?
| </file> | ||
| </example> | ||
| */ | ||
| angular.module('patternfly.views').component('pfEmptyState', { |
There was a problem hiding this comment.
Would prefer example code be in examples directory. Feel free to ignore.
There was a problem hiding this comment.
yeah, typically if there is more than one example I put them in the examples dir.
| }; | ||
|
|
||
| ctrl.areMainActions = function () { | ||
| var mainActions; |
There was a problem hiding this comment.
nit: would be clearer if functions were 'hasMainActions' and 'hasSecondaryActions'
|
|
||
| .blank-slate-pf button { | ||
| margin-right: 4px; | ||
| } |
There was a problem hiding this comment.
Should these be in patternfly? Maybe just add a comment to explain.
dtaylor113
force-pushed
the
branch-4.0-dev
branch
from
2d11a69 to
c63bec0
Compare
|
Hi @jeff-phillips-18 , addressed your review issues. |
dgutride
suggested changes
Jan 25, 2017
| @@ -79,14 +79,15 @@ Note: | |||
| <script src="node_modules/angular-patternfly/node_modules/patternfly/node_modules/c3/c3.min.js"></script> | |||
| <script src="node_modules/angular-patternfly/node_modules/patternfly/node_modules/d3/d3.min.js"></script> | |||
|
|
|||
| 5. (optional) The 'patternfly.charts' module is not a dependency in the default angular 'patternfly' module. | |||
| In order to use patternfly charts you must add 'patternfly.charts' as a dependency in your application: | |||
| 5. (optional) The 'patternfly.charts' and 'patternfly.table' modules are not a dependencies in the default angular 'patternfly' module. | |||
There was a problem hiding this comment.
Extra 'a' in this sentence (not a dependencies)
| 5. (optional) The 'patternfly.charts' module is not a dependency in the default angular 'patternfly' module. | ||
| In order to use patternfly charts you must add 'patternfly.charts' as a dependency in your application: | ||
| 5. (optional) The 'patternfly.charts' and 'patternfly.table' modules are not a dependencies in the default angular 'patternfly' module. | ||
| In order to use patternfly charts and/or patternfly.table, you must add them as a dependencies in your application: |
There was a problem hiding this comment.
Same as above - we should remove the extra 'a'
dgutride
approved these changes
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular-Patternfly Implementation of http://www.patternfly.org/pattern-library/communication/empty-state/#/api
pfEmptyState ngdoc:
pfEmptyState ngdoc examples for pfListView, pfCardView, pfTableView, and pfToolbar: