Skip to content

Commit c63bec0

Browse files
committed
Addressed review issues
1 parent 75138e7 commit c63bec0

File tree

5 files changed

+10
-8
lines changed

5 files changed

+10
-8
lines changed

src/views/cardview/card-view.component.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@
9090
<input type="checkbox" ng-model="showDisabled">Show Disabled Cards</input>
9191
</label>
9292
<label class="checkbox-inline">
93-
+ <input type="checkbox" ng-model="config.itemsAvailable">Items Available</input>
94-
+ </label>
93+
<input type="checkbox" ng-model="config.itemsAvailable">Items Available</input>
94+
</label>
9595
</div>
9696
</form>
9797
</div>
@@ -217,7 +217,7 @@ angular.module('patternfly.views').component('pfCardView', {
217217
},
218218
transclude: true,
219219
templateUrl: 'views/cardview/card-view.html',
220-
controller: function (pfUtils, $log) {
220+
controller: function () {
221221
'use strict';
222222
var ctrl = this;
223223
ctrl.defaultConfig = {

src/views/empty-state.component.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ angular.module('patternfly.views').component('pfEmptyState', {
116116
}
117117
};
118118

119-
ctrl.areMainActions = function () {
119+
ctrl.hasMainActions = function () {
120120
var mainActions;
121121

122122
if (ctrl.actionButtons) {
@@ -127,7 +127,7 @@ angular.module('patternfly.views').component('pfEmptyState', {
127127
return false;
128128
};
129129

130-
ctrl.areSecondaryActions = function () {
130+
ctrl.hasSecondaryActions = function () {
131131
var secondaryActions;
132132

133133
if (ctrl.actionButtons) {

src/views/empty-state.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@ <h1 id="title">
1111
<p id="helpLink" ng-if="$ctrl.config.helpLink">
1212
{{$ctrl.config.helpLink.label}} <a href="{{$ctrl.config.helpLink.url}}">{{$ctrl.config.helpLink.urlLabel}}</a>.
1313
</p>
14-
<div ng-if="$ctrl.areMainActions()" class="blank-slate-pf-main-action">
14+
<div ng-if="$ctrl.hasMainActions()" class="blank-slate-pf-main-action">
1515
<button class="btn btn-primary btn-lg"
1616
ng-repeat="actionButton in $ctrl.actionButtons | filter:$ctrl.filterMainActions"
1717
title="{{actionButton.title}}"
1818
ng-click="$ctrl.handleButtonAction(actionButton)">
1919
{{actionButton.name}}
2020
</button>
2121
</div>
22-
<div ng-if="$ctrl.areSecondaryActions()" class="blank-slate-pf-secondary-action">
22+
<div ng-if="$ctrl.hasSecondaryActions()" class="blank-slate-pf-secondary-action">
2323
<button class="btn btn-default"
2424
ng-repeat="actionButton in $ctrl.actionButtons | filter:$ctrl.filterSecondaryActions"
2525
title="{{actionButton.title}}"

src/views/listview/list-view.component.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ angular.module('patternfly.views').component('pfListView', {
420420
expandedContent: '?listExpandedContent'
421421
},
422422
templateUrl: 'views/listview/list-view.html',
423-
controller: function ($timeout, $window, $element, pfUtils) {
423+
controller: function ($timeout, $window, $element) {
424424
'use strict';
425425
var ctrl = this;
426426

styles/angular-patternfly.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -513,11 +513,13 @@ table.dataTable tbody th, table.dataTable tbody td {
513513
width: 13px;
514514
}
515515

516+
/* overriding pf base so that blank slate fills entire parent container */
516517
.blank-slate-pf {
517518
height:100%;
518519
margin-bottom: 0px;
519520
}
520521

522+
/* overriding pf base so that buttons have spaces between them */
521523
.blank-slate-pf button {
522524
margin-right: 4px;
523525
}

0 commit comments

Comments
 (0)