Abstracted rendering patterns to allow for other forms of rendering (eg.... #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivanmayes This is a smart improvement. I know there are other opportunities to make pl-node better too. @dmolsen Just sent us a specification-related note the other day regarding the templating engine - and this is certainly a step in the right direction. I will check likely merge your PR tonight. Thanks so much for using patternlab and pl-node! I appreciate the interest and support. Keep it up. |
|
I am going to close this PR. As you mentioned, the intent of this was handled in #49. Thanks again for the improvement, I will make sure to include in the next changelog. |
bmuenzenmeyer
pushed a commit
that referenced
this pull request
Feb 23, 2018
updated package.json semver
bmuenzenmeyer
pushed a commit
that referenced
this pull request
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our company (and I noticed that several forks of php and node) are attempting to use handlebars with the system. Abstracting the render function makes a nice clean way to customize your rendering.
Also, would be interesting to potentially build out separate rendering files for mustache and handlebars so that you could configure with templating method you prefer.