Abstracted template rendering; fixed issue with JSON files order in filesystem #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late in filesystem; cleaned up render function
bmuenzenmeyer
pushed a commit
that referenced
this pull request
Jul 16, 2014
Abstracted template rendering; fixed issue with JSON files order in filesystem
bmuenzenmeyer
pushed a commit
that referenced
this pull request
Feb 23, 2018
bmuenzenmeyer
pushed a commit
that referenced
this pull request
Feb 23, 2018
fix css refresh for chrome
bmuenzenmeyer
pushed a commit
that referenced
this pull request
Apr 17, 2020
feat: support scheduled and draft posts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies, have been fighting the pull request system here.... which is why the rendering piece is in this request as well, it should be the same as the other.
There was an issue with JSON files as we explored handlebars, the .hbs extension put the template ahead of the json in the filesystem, causing errors. We refactored the rendering process to just look for JSON and add it to the pattern's data along the way, and passing in global data if its null at render time. This cleaned up some of the function duplication and big if statements from the previous example.
Happy to make any adjustments if needed, thanks for getting this project going!