-
Notifications
You must be signed in to change notification settings - Fork 405
BREAKING-CHANGE: Deprecate underscore prefix #1237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bmuenzenmeyer @sghoweri @engelfrost @bradfrost @mfranzke @ringods To overcome the pattern and group name matching I consider an underscore prefix for version 1 if it is a companion Examples (Sorted like the filesystem would do)
!! please upvote with 🚀 if you like version 1 and with 👀 if you prefer version 2 !!EDIT: I know we have the top-level markdown files (as documentation patterns), which apply to version 2 in this example. The problem is, those are breaking the UI even without any change in the current version that no view all pages can be generated for folders with documentation blocks. Maybe we need to rethink how everything is working together. EDIT 2: Based on all the information I got from issues and also the spec, I can now confirm, that version 2 was somehow implemented but, on the other hand, not. References: #415, the-spec/#28 and also an old PR where I gathered some more information. I will now proceed to use version 2 since it is already implemented in some way. |
If I understand this correctly, I'm on team 🚀. Generally I think all the files for a subfolder should be in that folder so it's self-contained. In our theme we have a script that automatically generates a subfolder containing the necessary files (e.g., twig, md, scss and yml files). |
Keep in mind, this change is not for patterns. It is for groups and subgroups. But I'm totaly on you side. We also have scripts to create all required files in our company. |
See my edits on my initial question, "commented on 18 Aug.". There are some hints for testing. |
Closes #1209
Closes #1182
Closes #1183
Summary of changes:
Change the way pattern lab is hiding patterns. Because all those file system hacks are not a good approach we decided to remove this functionality in favor of a more flexible way.