-
Notifications
You must be signed in to change notification settings - Fork 405
BREAKING-CHANGE: Deprecate ordering by file-prefix ##- #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosefBredereck
added a commit
that referenced
this pull request
Aug 29, 2020
Curious about a few things related to this PR:
|
yes
yes, there will be a transition phase
maybe at the end of september |
Awesome, thanks! |
See my comments on #1237 for further information on testing. |
JosefBredereck
added a commit
that referenced
this pull request
Jan 7, 2021
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
) * Remove pattern ordering by file prefix ##- * pattern-lab#1252: Remove unused code * pattern-lab#1252 Update pattern doc locations * pattern-lab#1252 add possibility to disable deprecation warning * pattern-lab#1252 Fix dev engine twig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1028
Closes #1176
Summary of changes:
Remove the ability to sort files and folders by the ##- prefix. Since that approach could become unhandy when you want to reorder your patterns.
(Reopening to split changes in code and starter kit file changes)