Skip to content

Fix health check #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 1, 2021
Merged

Fix health check #34

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
603ded1
Fix health check
pcothenet Sep 1, 2021
ce2222a
Remove ignored files
pcothenet Sep 1, 2021
12c1ac4
Rename step
pcothenet Sep 1, 2021
96b5602
Failure only
pcothenet Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/healthcheck.yml → .github/workflows/health_check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,28 @@ on:
jobs:
build-and-test:
runs-on: ubuntu-latest
name: Python Library tests
name: Run tests
strategy:
matrix:
python: ['3.6']
steps:
- name: Check out code
uses: actions/checkout@v2

- name: Setup Python
uses: actions/setup-python@v2
with:
python-version: '3.6'
python-version: ${{ matrix.python }}

- name: Run tests
env:
SANDBOX_API_KEY: ${{ secrets.SANDBOX_API_KEY }}
run: make test

- name: Notify Slack
- name: Notify slack
uses: kpritam/slack-job-status-action@v1
with:
if: ${{ always() }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we care about success cases? If we're focused on keeping all alerts and notifications actionable, how about we just do failure()? Not a blocker, more a consideration to keep the noise down

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, should be failure(), looks I forgot that repo.

job-status: ${{ job.status }}
slack-bot-token: ${{ secrets.SLACK_BOT_TOKEN }}
channel: github-actions
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,7 @@ target/
#Ipython Notebook
.ipynb_checkpoints

git_push.sh
# Ignore openapi-generator artifacts
.openapi-generator-ignore
/.openapi-generator/
git_push.sh
23 changes: 0 additions & 23 deletions .openapi-generator-ignore
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion .openapi-generator/VERSION
View file
Open in desktop

This file was deleted.