Skip to content

Fix health check #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 1, 2021
Merged

Fix health check #34

merged 4 commits into from
Sep 1, 2021

Conversation

pcothenet
Copy link
Contributor

@pcothenet pcothenet commented Sep 1, 2021 •
edited
Loading

What

  • Fix the health check notifications to notify in case of errors
  • Remove openapi-generator artifacts

Notes

  • We were not seeing Slack notifications for this one simply because the Slack token secret wasn't shared with this repo. This is now fixed.
  • This doesn't require a release

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@pcothenet pcothenet requested a review from kleinjm September 1, 2021 18:44
kleinjm
kleinjm reviewed Sep 1, 2021
View reviewed changes
.github/workflows/health_check.yml Outdated
- name: Notify slack
uses: kpritam/slack-job-status-action@v1
with:
if: ${{ always() }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we care about success cases? If we're focused on keeping all alerts and notifications actionable, how about we just do failure()? Not a blocker, more a consideration to keep the noise down

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, should be failure(), looks I forgot that repo.

@pcothenet pcothenet merged commit 5caea32 into main Sep 1, 2021
@pcothenet pcothenet deleted the pc/healthcheck branch September 1, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kleinjm kleinjm kleinjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pcothenet @kleinjm