-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.10.1 #7508
Release 4.10.1 #7508
Conversation
Codecov Report
@@ Coverage Diff @@
## release-4.x.x #7508 +/- ##
================================================
Coverage ? 93.84%
================================================
Files ? 169
Lines ? 12428
Branches ? 0
================================================
Hits ? 11663
Misses ? 765
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @davimacedo; @dblythy could you review this PR and let us know your opinion on the approach described above? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Not sure if it's already been done, but perhaps we could have a quick blog post "migrating to the new mail adapter" or something like that. I know in the past depreciations of commonly used adaptors can be tedious, and prevent people from updating.
Thanks for the review! Implementing the new adapter should hopefully be understandable from the docs of the new adapter. Let me know if there is anything you think should be improved by opening an issue there. I think adding any migration information there would probably be more accessible for people who navigate there to implement the new adapter. |
Right, sounds good! I think I had some minor troubles implementing it myself, but was easy to solve. Also, should that repo be transferred to the Parse Org if it's an official adapter? |
Sure, let me know any suggestions for improvement. The adapter is not an official org adapter at this point (for various reasons), but I plan to transfer it in the future. |
Squashed commits: [1306da7] Merge pull request from GHSA-23r4-5mxp-c7g5 [3a5c38d] revert to version 4.5.0 for testing [a3483d8] fix changelog skip 4.5.1 [3c42584] 4.5.2 [97b1dca] revert to version 4.5.0 for testing [f3133ac] Release 4.10.1 (parse-community#7508) * bump parse 3.3.0 * Update CHANGELOG.md * update user test (PR parse-community#7464) * fix Twitter API oauth Error (PR parse-community#7370) * bumped dependencies * Revert "bumped dependencies" This reverts commit 97ad83d. * bump @parse/push-adapter 3.4.1 * bump jwks-rsa@1.12.3 * bump mongodb@3.6.11 * bump ws@7.5.3 * changed logging for circular obj (PR parse-community#7457) * Update CHANGELOG.md [7e1da90] added changelog [0e3cae5] audit fix [f0d5232] bumped version [4ac4b7f] Merge pull request from GHSA-7pr3-p5fm-8r9x * fix: LQ deletes session token * add 4.10.4 * add changes [ef2ec21] ci: update docker image building (parse-community#7553) * docker * Update docker-publish.yml * Update docker-publish.yml [6ae5835] Merge pull request from GHSA-xqp8-w826-hh6x * Backport the advisory fix * Added a 4.10.3 section to CHANGELOG [0bfa6b7] Release 4.10.2 (parse-community#7513) * move graphql-tag from devDependencies to dependencies (parse-community#7183) * bump version * Update CHANGELOG.md [0be0b87] bump version
Squashed commits: [1306da7] Merge pull request from GHSA-23r4-5mxp-c7g5 [3a5c38d] revert to version 4.5.0 for testing [a3483d8] fix changelog skip 4.5.1 [3c42584] 4.5.2 [97b1dca] revert to version 4.5.0 for testing [f3133ac] Release 4.10.1 (parse-community#7508) * bump parse 3.3.0 * Update CHANGELOG.md * update user test (PR parse-community#7464) * fix Twitter API oauth Error (PR parse-community#7370) * bumped dependencies * Revert "bumped dependencies" This reverts commit 97ad83d. * bump @parse/push-adapter 3.4.1 * bump jwks-rsa@1.12.3 * bump mongodb@3.6.11 * bump ws@7.5.3 * changed logging for circular obj (PR parse-community#7457) * Update CHANGELOG.md [7e1da90] added changelog [0e3cae5] audit fix [f0d5232] bumped version [4ac4b7f] Merge pull request from GHSA-7pr3-p5fm-8r9x * fix: LQ deletes session token * add 4.10.4 * add changes [ef2ec21] ci: update docker image building (parse-community#7553) * docker * Update docker-publish.yml * Update docker-publish.yml [6ae5835] Merge pull request from GHSA-xqp8-w826-hh6x * Backport the advisory fix * Added a 4.10.3 section to CHANGELOG [0bfa6b7] Release 4.10.2 (parse-community#7513) * move graphql-tag from devDependencies to dependencies (parse-community#7183) * bump version * Update CHANGELOG.md [0be0b87] bump version
Release 4.10.1
The objective of this release is to reduce the vulnerabilities from
1 low, 6 moderate, 2 high
in 4.10.0 to1 low, 1 high
.The remaining high vulnerability is due to the now deprecated
@parse/simple-mailgun-adapter
. This can easily be fixed by the developer by not using the adapter. There is an up-to-date mailgun adapter as replacement, but it works differently.The bump from Parse 2.x to 3.x contains a breaking change:
This change prevents the plain text username and password from being in URLs and log files, a significant security issue.
If we argue that a security issue is usually not considered a braking change, because it doesn't "break" anything, but "fixes" something that is currently broken, we could release a parse server 4.10.1 that is free of any significant vulnerabilities. I think that approach is required once we move to Long Term Support, otherwise we could never fix vulnerabilities in a 4.x release while maintaining a 5.x release at the same time. In that sense, the fix in Parse would probably not have justified the major version bump from 2.x to 3.x.
Bottom line, this will make Parse Server 4.x usable again without any significant vulnerability until we release Parse Server 5.0.
Note
release-4.x.x
and don't delete that branch, it is the LTS branch for 4.x.x, a good exercise for our LTS trial to come.TODO