Skip to content

Conversation

davimacedo
Copy link
Member

New Pull Request Checklist

  • [ X ] I am not disclosing a vulnerability.
  • [ X ] I am creating this PR in reference to an issue.

Issue Description

graphql-tag is required by one of the GraphQL files:

import gql from 'graphql-tag';

Related issue: close #7182

Approach

Move graphql-tag from devDependencies to dependencies

TODOs before merging

  • [ N/A ] Add test cases
  • [ X ] Add entry to changelog
  • [ N/A ] Add changes to documentation (guides, repository pages, in-code descriptions)
  • [ N/A ] Add security check
  • [ N/A ] Add new Parse Error codes to Parse JS SDK
  • [ N/A ] ...

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #7183 (670bf61) into master (2b9b336) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7183   +/-   ##
=======================================
  Coverage   94.01%   94.02%           
=======================================
  Files         172      172           
  Lines       12913    12913           
=======================================
+ Hits        12140    12141    +1     
+ Misses        773      772    -1     
Impacted Files Coverage Δ
src/RestWrite.js 94.00% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b9b336...77b2810. Read the comment docs.

@davimacedo
Copy link
Member Author

@dplewis @mtrezza any idea why CI Self-Check is failing?

@dplewis
Copy link
Member

dplewis commented Feb 12, 2021

Looks like a mongo patch 4.4.4 was release and we test 4.4.3

@davimacedo
Copy link
Member Author

Maybe we should enforce that for releasing but not for every commit. I will try to fix anyways.

@mtrezza
Copy link
Member

mtrezza commented Feb 12, 2021

I will look into auto-creating a PR with the updated version, like Snyk, to reduce the effort.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit cd78f89 into parse-community:master Mar 1, 2021
mtrezza added a commit to mtrezza/parse-server that referenced this pull request Aug 23, 2021
mtrezza added a commit that referenced this pull request Aug 23, 2021
* move graphql-tag from devDependencies to dependencies (#7183)

* bump version

* Update CHANGELOG.md
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
SebC99 pushed a commit to hulab/parse-server that referenced this pull request May 29, 2022
Squashed commits:
[1306da7] Merge pull request from GHSA-23r4-5mxp-c7g5
[3a5c38d] revert to version 4.5.0 for testing
[a3483d8] fix changelog skip 4.5.1
[3c42584] 4.5.2
[97b1dca] revert to version 4.5.0 for testing
[f3133ac] Release 4.10.1 (parse-community#7508)

* bump parse 3.3.0

* Update CHANGELOG.md

* update user test (PR parse-community#7464)

* fix Twitter API oauth Error (PR parse-community#7370)

* bumped dependencies

* Revert "bumped dependencies"

This reverts commit 97ad83d.

* bump @parse/push-adapter 3.4.1

* bump jwks-rsa@1.12.3

* bump mongodb@3.6.11

* bump ws@7.5.3

* changed logging for circular obj (PR parse-community#7457)

* Update CHANGELOG.md
[7e1da90] added changelog
[0e3cae5] audit fix
[f0d5232] bumped version
[4ac4b7f] Merge pull request from GHSA-7pr3-p5fm-8r9x

* fix: LQ deletes session token

* add 4.10.4

* add changes
[ef2ec21] ci: update docker image building (parse-community#7553)

* docker

* Update docker-publish.yml

* Update docker-publish.yml
[6ae5835] Merge pull request from GHSA-xqp8-w826-hh6x

* Backport the advisory fix

* Added a 4.10.3 section to CHANGELOG
[0bfa6b7] Release 4.10.2 (parse-community#7513)

* move graphql-tag from devDependencies to dependencies (parse-community#7183)

* bump version

* Update CHANGELOG.md
[0be0b87] bump version
SebC99 pushed a commit to hulab/parse-server that referenced this pull request Nov 10, 2022
Squashed commits:
[1306da7] Merge pull request from GHSA-23r4-5mxp-c7g5
[3a5c38d] revert to version 4.5.0 for testing
[a3483d8] fix changelog skip 4.5.1
[3c42584] 4.5.2
[97b1dca] revert to version 4.5.0 for testing
[f3133ac] Release 4.10.1 (parse-community#7508)

* bump parse 3.3.0

* Update CHANGELOG.md

* update user test (PR parse-community#7464)

* fix Twitter API oauth Error (PR parse-community#7370)

* bumped dependencies

* Revert "bumped dependencies"

This reverts commit 97ad83d.

* bump @parse/push-adapter 3.4.1

* bump jwks-rsa@1.12.3

* bump mongodb@3.6.11

* bump ws@7.5.3

* changed logging for circular obj (PR parse-community#7457)

* Update CHANGELOG.md
[7e1da90] added changelog
[0e3cae5] audit fix
[f0d5232] bumped version
[4ac4b7f] Merge pull request from GHSA-7pr3-p5fm-8r9x

* fix: LQ deletes session token

* add 4.10.4

* add changes
[ef2ec21] ci: update docker image building (parse-community#7553)

* docker

* Update docker-publish.yml

* Update docker-publish.yml
[6ae5835] Merge pull request from GHSA-xqp8-w826-hh6x

* Backport the advisory fix

* Added a 4.10.3 section to CHANGELOG
[0bfa6b7] Release 4.10.2 (parse-community#7513)

* move graphql-tag from devDependencies to dependencies (parse-community#7183)

* bump version

* Update CHANGELOG.md
[0be0b87] bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local setup fails stating Cannot find module 'graphql-tag'
4 participants