Add tests against multiple MongoDB versions #7161

mtrezza · 2021-02-02T02:59:30Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Add tests for multiple MongoDB versions.

Related issue: closes #7160

Approach

Added MongoDB versions in CI matrix.
Added spec helper it_only_mongodb_version(version) that only executes a test if the specified semver version satisfies the MongoDB version; allows to write duplicates tests for MongoDB versions and easily discard them by their semver notation once testing for a specific MongoDB version is removed from the CI.
Added npm scripts to easily run tests against the relevant MongoDB versions that have to pass in the CI, e.g. npm run test:mongodb:4.4.3; or simply run against any version the developer prefers with npm run test:mongodb --dbversion=[VERSION].

TODOs before merging

Ensure the latests patch of each officially supported MongoDB version is tested in CI
Ensure CI tests pass
Add MongoDB compatibility table to README.md
Add entry to changelog

* commit 'ccb045b68c5b4d983a90fa125513fc476e4e2387': fix: upgrade @graphql-tools/links from 6.2.4 to 6.2.5 (parse-community#7007) fix: upgrade pg-promise from 10.7.0 to 10.7.1 (parse-community#7009) fix: upgrade jwks-rsa from 1.10.1 to 1.11.0 (parse-community#7008) fix: upgrade graphql from 15.3.0 to 15.4.0 (parse-community#7011) update stale bot (parse-community#6998) fix(beforeSave/afterSave): Return value instead of Parse.Op for nested fields (parse-community#7005) fix(beforeSave): Skip Sanitizing Database results (parse-community#7003) Fix includeAll for querying a Pointer and Pointer array (parse-community#7002) Init (parse-community#6999)

codecov · 2021-02-02T03:08:41Z

Codecov Report

Merging #7161 (da89ea0) into master (5584da5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7161      +/-   ##
==========================================
+ Coverage   93.90%   93.92%   +0.02%     
==========================================
  Files         169      169              
  Lines       12547    12547              
==========================================
+ Hits        11782    11785       +3     
+ Misses        765      762       -3

Impacted Files	Coverage Δ
src/RestQuery.js	`95.52% <100.00%> (ø)`
src/Controllers/DatabaseController.js	`95.46% <0.00%> (-0.15%)`	⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js	`95.85% <0.00%> (-0.08%)`	⬇️
src/RestWrite.js	`94.00% <0.00%> (+0.32%)`	⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js	`93.51% <0.00%> (+0.67%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5584da5...f743b0e. Read the comment docs.

…ctions)

dplewis · 2021-02-02T23:08:32Z

We did run into an issue when we where trying to migrate to Github Actions. We use 4.0.4 of mongo since it was the only version that works with the tests. You can view the conversation (trial and error) here

…e collection

mtrezza · 2021-02-03T02:39:36Z

@dplewis All test pass now, they did not pass because:

some were poorly written and did not follow MongoDB specification, MongoDB 4.4 is more strict about that
some had to be adapted to different behavior in different versions of MongoDB
some bugs had to be fixed in Parse Server itself

In fact, Parse Server was not fully compatible since MongoDB 4.2 (2019).

To make sure this doesn't happen again, I added a compatibility table to the README. We should keep an eye on the MongoDB support policy and update the MongoDB versions we test against. Maybe subscribe our official email to release announcements. @TomWFox Any idea how we can remind ourselves regularly?

TODOs after merging this PR:

In April 2021 MongoDB 3.6 reaches its end of life support. We can (and I think should) then remove it from the CI tests to focus on the newer versions.
Regularly update the patch versions for all MongoDB minor versions; MongoDB still releases patches for versions <4.4, see compatibility table.

…Elastic Beanstalk)

mtrezza · 2021-02-07T13:32:46Z

If there is no objection, I will go ahead and merge this later today.

…-localization * commit 'b59517fd68a56885c9ab73525526e42ff4003333': Add tests against multiple MongoDB versions (parse-community#7161) # Conflicts: # CHANGELOG.md # README.md # package-lock.json

* commit '7f47b0427ea56214d9b0199f0fcfa4af38794e02': Add page localization (parse-community#7128) Improve contribution guide (parse-community#7075) fix: upgrade pg-promise from 10.9.0 to 10.9.1 (parse-community#7170) Add tests against multiple MongoDB versions (parse-community#7161) fix: upgrade mime from 2.4.7 to 2.5.0 (parse-community#7166) fix: upgrade pg-promise from 10.8.7 to 10.9.0 (parse-community#7168) fix: upgrade apollo-server-express from 2.19.1 to 2.19.2 (parse-community#7165) Upgrade @node-rs/bcrypt to latest version (parse-community#7159) Run Prettier after Definitions (parse-community#7164)

mtrezza · 2021-02-10T16:49:20Z

I noticed that the Parse Server repo only has Snyk as required passing test. Shouldn't these MongoDB tests and the others (Postgres, Node 12) be required as well? @davimacedo @dplewis

davimacedo · 2021-02-12T06:53:19Z

Where do you see that @mtrezza ?

mtrezza · 2021-02-12T08:48:33Z

In the repo Settings > Branches > Branch Protection Rules > Edit > Require status checks to pass before merging.

davimacedo · 2021-02-12T21:51:23Z

Yes. I've just seem it here. I believe we should include these checks. @dplewis thoughts?

dplewis · 2021-02-12T21:59:14Z

I agree, I never noticed out of habit.

davimacedo · 2021-02-12T22:05:17Z

I've just activated. Let's see how it works.

* added tests environment with mongodb 4.4.3 * added CI test for mongodb 4.4.3 * added CI tests for MongoDB versions 4.0, 4.2 * improved flaky test (seems to max out the limit of simultaneous connections) * added spec helpers to run tests only for specific MongoDB version * addedn npm scripts to run tests against relevant mongodb versions * added spec helper function to exclude specific mongodb version * added test for changed aggregate query planner results * fixed regex test with incorrect regex syntax * fixed test where query has select no keys (empty array) * added changelog entry and ordered list * fixed test that tried to simultaneously delete and build index on same collection * added MongoDB compatibility table to readme * updated default local tests to use MongoDB 4.4.3 * added MongoDB badges for new versions to README * fixed typo in readme * added new test helper filter to contribution guide * fixed incorrect storage engine for mongodb 4.4 * changed CI to test MongoDB 3.6. with mmapv1 storage engine and standalone * improved CI test description * added CI self check for new MongoDB versions * fixed CI * removed CI * added CI * added throwing error if any of the checks failed * added github action connector * improved error message * improved error messages * improved error message * updated CI environment to MongoDB 3.6.22 * improved error messages * update CI env name * updated CI env name * improved error message * removed patch versions from CI env description * improved status message * removed version range from core lib * added explicit mongodb version to redis test and node 12 test * bumped Node 12 test to 12.20.1 (version currently recommended by AWS Elastic Beanstalk)

parseplatformorg · 2021-11-01T16:34:42Z

🎉 This change has been released in version 5.0.0-beta.1

parseplatformorg · 2022-03-14T13:06:56Z

🎉 This change has been released in version 5.0.0

mtrezza and others added 14 commits November 19, 2020 01:05

Merge remote-tracking branch 'upstream/master'

4d72525

Merge remote-tracking branch 'upstream/master'

65a6bdb

Merge remote-tracking branch 'upstream/master'

50274b8

Merge remote-tracking branch 'upstream/master'

3b337cd

Merge remote-tracking branch 'upstream/master'

073f0fc

Merge remote-tracking branch 'upstream/master'

2ee5907

Merge remote-tracking branch 'upstream/master'

241a1d8

Merge remote-tracking branch 'upstream/master'

4f097ce

Merge remote-tracking branch 'upstream/master'

8f3ea1c

Merge remote-tracking branch 'upstream/master'

4743cbc

Merge remote-tracking branch 'upstream/master'

59de429

Merge remote-tracking branch 'upstream/master'

ed2944f

added tests environment with mongodb 4.4.3

cb63152

mtrezza added 5 commits February 2, 2021 20:37

added CI test for mongodb 4.4.3

cb84664

added CI tests for MongoDB versions 4.0, 4.2

5427c19

improved flaky test (seems to max out the limit of simultaneous conne…

3bc43a0

…ctions)

added spec helpers to run tests only for specific MongoDB version

b6e6071

addedn npm scripts to run tests against relevant mongodb versions

14c42e3

mtrezza added 7 commits February 3, 2021 00:21

added spec helper function to exclude specific mongodb version

2808854

added test for changed aggregate query planner results

985d24e

fixed regex test with incorrect regex syntax

e4bf277

fixed test where query has select no keys (empty array)

8425da9

added changelog entry and ordered list

b5d1d9f

fixed test that tried to simultaneously delete and build index on sam…

594f78e

…e collection

added MongoDB compatibility table to readme

4c33b19

updated default local tests to use MongoDB 4.4.3

b18c900

mtrezza added 10 commits February 4, 2021 22:32

updated CI environment to MongoDB 3.6.22

16a2a7b

improved error messages

216b72d

update CI env name

bfcd4a5

updated CI env name

6cb3ae2

improved error message

3cbb638

removed patch versions from CI env description

424de2f

improved status message

d885fd5

removed version range from core lib

d9b53fc

added explicit mongodb version to redis test and node 12 test

8f90104

bumped Node 12 test to 12.20.1 (version currently recommended by AWS …

f743b0e

…Elastic Beanstalk)

davimacedo approved these changes Feb 7, 2021

View reviewed changes

mtrezza merged commit b59517f into parse-community:master Feb 7, 2021

mtrezza deleted the fix-mongodb-4.4 branch February 7, 2021 22:27

cbaker6 mentioned this pull request Feb 11, 2021

Test against multiple versions of Postgres #7176

Merged

6 tasks

mtrezza mentioned this pull request Mar 5, 2021

Select and Exclude queries do not properly digest JSON arrays #7245

Closed

6 tasks

parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021

mtrezza mentioned this pull request Mar 12, 2022

build: release 5.0 #7851

Merged

parseplatformorg added the state:released Released as stable version label Mar 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests against multiple MongoDB versions #7161

Add tests against multiple MongoDB versions #7161

mtrezza commented Feb 2, 2021 •

edited

Loading

codecov bot commented Feb 2, 2021 •

edited

Loading

dplewis commented Feb 2, 2021

mtrezza commented Feb 3, 2021 •

edited

Loading

mtrezza commented Feb 7, 2021

mtrezza commented Feb 10, 2021 •

edited

Loading

davimacedo commented Feb 12, 2021

mtrezza commented Feb 12, 2021

davimacedo commented Feb 12, 2021

dplewis commented Feb 12, 2021

davimacedo commented Feb 12, 2021

parseplatformorg commented Nov 1, 2021

parseplatformorg commented Mar 14, 2022

Add tests against multiple MongoDB versions #7161

Add tests against multiple MongoDB versions #7161

Conversation

mtrezza commented Feb 2, 2021 • edited Loading

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

codecov bot commented Feb 2, 2021 • edited Loading

Codecov Report

dplewis commented Feb 2, 2021

mtrezza commented Feb 3, 2021 • edited Loading

mtrezza commented Feb 7, 2021

mtrezza commented Feb 10, 2021 • edited Loading

davimacedo commented Feb 12, 2021

mtrezza commented Feb 12, 2021

davimacedo commented Feb 12, 2021

dplewis commented Feb 12, 2021

davimacedo commented Feb 12, 2021

parseplatformorg commented Nov 1, 2021

parseplatformorg commented Mar 14, 2022

mtrezza commented Feb 2, 2021 •

edited

Loading

codecov bot commented Feb 2, 2021 •

edited

Loading

mtrezza commented Feb 3, 2021 •

edited

Loading

mtrezza commented Feb 10, 2021 •

edited

Loading