Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(beforeSave/afterSave): Return value instead of Parse.Op for nested fields #7005

Merged
merged 4 commits into from
Nov 12, 2020

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Nov 12, 2020

Fixes issue where any op would be displayed in JSON format.
object.get('objectField').number // { __op: 'Increment', amount: 10 }

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #7005 (57b3a81) into master (a4c84c0) will increase coverage by 0.02%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7005      +/-   ##
==========================================
+ Coverage   93.81%   93.84%   +0.02%     
==========================================
  Files         169      169              
  Lines       12405    12407       +2     
==========================================
+ Hits        11638    11643       +5     
+ Misses        767      764       -3     
Impacted Files Coverage Δ
src/RestWrite.js 93.84% <88.88%> (+0.18%) ⬆️
src/Adapters/Files/GridFSBucketAdapter.js 79.50% <0.00%> (-0.82%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.58% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c84c0...57b3a81. Read the comment docs.

@dplewis dplewis changed the title fix(beforeSave): Return value instead of Parse.Op fix(beforeSave/afterSave): Return value instead of Parse.Op for nested fields Nov 12, 2020
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit c1971b2 into master Nov 12, 2020
@davimacedo davimacedo deleted the beforeSave-ops branch November 12, 2020 21:14
mtrezza added a commit to mtrezza/parse-server that referenced this pull request Dec 4, 2020
* commit 'ccb045b68c5b4d983a90fa125513fc476e4e2387':
  fix: upgrade @graphql-tools/links from 6.2.4 to 6.2.5 (parse-community#7007)
  fix: upgrade pg-promise from 10.7.0 to 10.7.1 (parse-community#7009)
  fix: upgrade jwks-rsa from 1.10.1 to 1.11.0 (parse-community#7008)
  fix: upgrade graphql from 15.3.0 to 15.4.0 (parse-community#7011)
  update stale bot (parse-community#6998)
  fix(beforeSave/afterSave): Return value instead of Parse.Op for nested fields (parse-community#7005)
  fix(beforeSave): Skip Sanitizing Database results (parse-community#7003)
  Fix includeAll for querying a Pointer and Pointer array (parse-community#7002)
  Init (parse-community#6999)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants